From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f197.google.com (mail-wr0-f197.google.com [209.85.128.197]) by kanga.kvack.org (Postfix) with ESMTP id BF67D6B0069 for ; Tue, 26 Sep 2017 22:54:13 -0400 (EDT) Received: by mail-wr0-f197.google.com with SMTP id b9so14155404wra.3 for ; Tue, 26 Sep 2017 19:54:13 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id r18si8094765wrg.257.2017.09.26.19.54.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Sep 2017 19:54:12 -0700 (PDT) Date: Tue, 26 Sep 2017 19:54:09 -0700 From: Andrew Morton Subject: Re: [PATCH v4] mm: introduce validity check on vm dirtiness settings Message-Id: <20170926195409.0867d13620e1219ca6676821@linux-foundation.org> In-Reply-To: References: <1506035552-13010-1-git-send-email-laoar.shao@gmail.com> <20170926165949.77e27aea0b92a226e7905060@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Yafang Shao Cc: linux-mm@kvack.org On Wed, 27 Sep 2017 09:38:21 +0800 Yafang Shao wrote: > > And existing scripts which do not do this will cease to work correctly, > > no? > > > > The existing scritpts won't work correctly. That's also what I have > worried before. > > But under this condition, there's a error message generated by "sysctl > -w" to tell them the first setting was failure. > This error message may be a reminder to them that there are some > connections between background and direct limit, and should not set > arbitrary. > May that's better. I'm not sure. Maybe we can leave the logic as-is and simply print a warning when an illogical state exists. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org