linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: changbin.du@intel.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm: update comments for struct page.mapping
Date: Tue, 26 Sep 2017 16:30:27 -0700	[thread overview]
Message-ID: <20170926163027.12836f5006745fcf6e59ad24@linux-foundation.org> (raw)
In-Reply-To: <1506410057-22316-1-git-send-email-changbin.du@intel.com>

On Tue, 26 Sep 2017 15:14:17 +0800 changbin.du@intel.com wrote:

> From: Changbin Du <changbin.du@intel.com>
> 
> The struct page.mapping can NULL or points to one object of type
> address_space, anon_vma or KSM private structure.
> 
> ...
>
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -47,8 +47,8 @@ struct page {
>  						 * inode address_space, or NULL.
>  						 * If page mapped as anonymous
>  						 * memory, low bit is set, and
> -						 * it points to anon_vma object:
> -						 * see PAGE_MAPPING_ANON below.
> +						 * it points to anon_vma object
> +						 * or KSM private structure.
>  						 */
>  		void *s_mem;			/* slab first object */
>  		atomic_t compound_mapcount;	/* first tail page */

Why did you remove the (useful) reference to PAGE_MAPPING_ANON?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-09-26 23:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-26  7:14 changbin.du
2017-09-26 23:30 ` Andrew Morton [this message]
2017-09-27  3:59   ` Du, Changbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170926163027.12836f5006745fcf6e59ad24@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=changbin.du@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox