From: Michal Hocko <mhocko@kernel.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Vlastimil Babka <vbabka@suse.cz>
Subject: Re: [PATCHv2] mm: Account pud page tables
Date: Tue, 26 Sep 2017 12:14:16 +0200 [thread overview]
Message-ID: <20170926101416.qzv6hurrrfmbefc5@dhcp22.suse.cz> (raw)
In-Reply-To: <20170926094344.t4cws4v4vrie5de5@node.shutemov.name>
On Tue 26-09-17 12:43:44, Kirill A. Shutemov wrote:
> On Mon, Sep 25, 2017 at 03:53:05PM +0200, Michal Hocko wrote:
> > On Mon 25-09-17 16:07:15, Kirill A. Shutemov wrote:
> > > On Mon, Sep 25, 2017 at 01:54:30PM +0200, Michal Hocko wrote:
> > > > On Mon 25-09-17 10:39:13, Kirill A. Shutemov wrote:
> > > > > On machine with 5-level paging support a process can allocate
> > > > > significant amount of memory and stay unnoticed by oom-killer and
> > > > > memory cgroup. The trick is to allocate a lot of PUD page tables.
> > > > > We don't account PUD page tables, only PMD and PTE.
> > > > >
> > > > > We already addressed the same issue for PMD page tables, see
> > > > > dc6c9a35b66b ("mm: account pmd page tables to the process").
> > > > > Introduction 5-level paging bring the same issue for PUD page tables.
> > > > >
> > > > > The patch expands accounting to PUD level.
> > > >
> > > > OK, we definitely need this or something like that but I really do not
> > > > like how much code we actually need for each pte level for accounting.
> > > > Do we really need to distinguish each level? Do we have any arch that
> > > > would use a different number of pages to back pte/pmd/pud?
> > >
> > > Looks like we actually do. At least on mips. See PMD_ORDER/PUD_ORDER.
> >
> > Hmm, but then oom_badness does consider them a single page which is
> > wrong. I haven't checked other users. Anyway even if we've had different
> > sizes why cannot we deal with this in callers. They know which level of
> > page table they allocate/free, no?
>
> So do you want to see single counter for all page table levels?
I think it would make the code easier to maintain and follow. As a
follow up for this patch which I am willing to ack.
> Do we have anybody who relies on VmPTE/VmPMD now?
No idea. I would just account everything to the pte level. If somebody
complains we can revert that part. But the value has been exported since
dc6c9a35b66b ("mm: account pmd page tables to the process") and I
suspect you have done so just to keep it in sync the existing VmPTE
without an explicit usecase in mind, right?
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-26 10:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-25 7:39 Kirill A. Shutemov
2017-09-25 11:54 ` Michal Hocko
2017-09-25 13:07 ` Kirill A. Shutemov
2017-09-25 13:53 ` Michal Hocko
2017-09-26 9:43 ` Kirill A. Shutemov
2017-09-26 10:14 ` Michal Hocko [this message]
2017-09-26 10:17 ` Michal Hocko
2017-10-01 0:38 ` kbuild test robot
2017-10-01 1:03 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170926101416.qzv6hurrrfmbefc5@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox