From: Michal Hocko <mhocko@suse.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
David Rientjes <rientjes@google.com>,
Manish Jaggi <mjaggi@caviumnetworks.com>,
Oleg Nesterov <oleg@redhat.com>,
Vladimir Davydov <vdavydov@virtuozzo.com>
Subject: Re: [PATCH] [PATCH v3] mm, oom: task_will_free_mem(current) should ignore MMF_OOM_SKIP for once.
Date: Mon, 25 Sep 2017 16:30:52 +0200 [thread overview]
Message-ID: <20170925143052.a57bqoiw6yuckwee@dhcp22.suse.cz> (raw)
In-Reply-To: <1506070646-4549-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
On Fri 22-09-17 17:57:26, Tetsuo Handa wrote:
[...]
> Michal Hocko has nacked this patch [3], and he suggested an alternative
> patch [4]. But he himself is not ready to clarify all the concerns with
> the alternative patch [5]. In addition to that, nobody is interested in
> either patch; we can not make progress here. Let's choose this patch for
> now, for this patch has smaller impact than the alternative patch.
My Nack stands and it is really annoying you are sending a patch for
inclusion regardless of that fact. An alternative approach has been
proposed and the mere fact that I do not have time to pursue this
direction is not reason to go with a incomplete solution. This is not an
issue many people would be facing to scream for a quick and dirty
workarounds AFAIK (there have been 0 reports from non-artificial
workloads).
> [1] http://lkml.kernel.org/r/e6c83a26-1d59-4afd-55cf-04e58bdde188@caviumnetworks.com
> [2] http://lkml.kernel.org/r/201708090835.ICI69305.VFFOLMHOStJOQF@I-love.SAKURA.ne.jp
> [3] http://lkml.kernel.org/r/20170821084307.GB25956@dhcp22.suse.cz
> [4] http://lkml.kernel.org/r/1503577106-9196-2-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp
> [5] http://lkml.kernel.org/r/20170918064353.v35prpp6bkkbgqr6@dhcp22.suse.cz
>
> Fixes: 696453e66630ad45 ("mm, oom: task_will_free_mem should skip oom_reaped tasks")
> Reported-by: Manish Jaggi <mjaggi@caviumnetworks.com>
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Oleg Nesterov <oleg@redhat.com>
> Cc: Vladimir Davydov <vdavydov@virtuozzo.com>
> Cc: David Rientjes <rientjes@google.com>
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next parent reply other threads:[~2017-09-25 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1506070646-4549-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp>
2017-09-25 14:30 ` Michal Hocko [this message]
2017-09-25 15:09 ` Tetsuo Handa
2017-09-26 11:27 ` [PATCH] mm,oom: Warn on racing with MMF_OOM_SKIP at task_will_free_mem(current) Tetsuo Handa
2017-09-26 11:39 ` Michal Hocko
2017-09-27 5:00 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170925143052.a57bqoiw6yuckwee@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mjaggi@caviumnetworks.com \
--cc=oleg@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=rientjes@google.com \
--cc=vdavydov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox