From: Timofey Titovets <nefelim4ag@gmail.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, borntraeger@de.ibm.com,
kvm@vger.kernel.org, Timofey Titovets <nefelim4ag@gmail.com>
Subject: [PATCH v2 1/2] xxHash: create arch dependent 32/64-bit xxhash()
Date: Fri, 22 Sep 2017 12:52:24 +0300 [thread overview]
Message-ID: <20170922095225.343-2-nefelim4ag@gmail.com> (raw)
In-Reply-To: <20170922095225.343-1-nefelim4ag@gmail.com>
xxh32() - fast on both 32/64-bit platforms
xxh64() - fast only on 64-bit platform
Create xxhash() which will pickup fastest version
on compile time.
Add type xxhash_t to map correct hash size.
As result depends on cpu word size,
the main proporse of that - in memory hashing.
Signed-off-by: Timofey Titovets <nefelim4ag@gmail.com>
Acked-by: Andi Kleen <ak@linux.intel.com>
Cc: Linux-kernel <linux-kernel@vger.kernel.org>
---
include/linux/xxhash.h | 24 ++++++++++++++++++++++++
lib/xxhash.c | 10 ++++++++++
2 files changed, 34 insertions(+)
diff --git a/include/linux/xxhash.h b/include/linux/xxhash.h
index 9e1f42cb57e9..195a0ae10e9b 100644
--- a/include/linux/xxhash.h
+++ b/include/linux/xxhash.h
@@ -76,6 +76,7 @@
#define XXHASH_H
#include <linux/types.h>
+#include <linux/bitops.h> /* BITS_PER_LONG */
/*-****************************
* Simple Hash Functions
@@ -107,6 +108,29 @@ uint32_t xxh32(const void *input, size_t length, uint32_t seed);
*/
uint64_t xxh64(const void *input, size_t length, uint64_t seed);
+#if BITS_PER_LONG == 64
+typedef u64 xxhash_t;
+#else
+typedef u32 xxhash_t;
+#endif
+
+/**
+ * xxhash() - calculate 32/64-bit hash based on cpu word size
+ *
+ * @input: The data to hash.
+ * @length: The length of the data to hash.
+ * @seed: The seed can be used to alter the result predictably.
+ *
+ * This function always work as xxh32() for 32-bit systems
+ * and as xxh64() for 64-bit systems.
+ * Because result depends on cpu work size,
+ * the main proporse of that function is for in memory hashing.
+ *
+ * Return: 32/64-bit hash of the data.
+ */
+
+xxhash_t xxhash(const void *input, size_t length, uint64_t seed);
+
/*-****************************
* Streaming Hash Functions
*****************************/
diff --git a/lib/xxhash.c b/lib/xxhash.c
index aa61e2a3802f..7dd1105fcc30 100644
--- a/lib/xxhash.c
+++ b/lib/xxhash.c
@@ -236,6 +236,16 @@ uint64_t xxh64(const void *input, const size_t len, const uint64_t seed)
}
EXPORT_SYMBOL(xxh64);
+xxhash_t xxhash(const void *input, size_t length, uint64_t seed)
+{
+#if BITS_PER_LONG == 64
+ return xxh64(input, length, seed);
+#else
+ return xxh32(input, length, seed);
+#endif
+}
+EXPORT_SYMBOL(xxhash);
+
/*-**************************************************
* Advanced Hash Functions
***************************************************/
--
2.14.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-22 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-22 9:52 [PATCH v2 0/2] KSM: Replace jhash2 with xxhash Timofey Titovets
2017-09-22 9:52 ` Timofey Titovets [this message]
2017-09-22 9:52 ` [PATCH v2 2/2] " Timofey Titovets
-- strict thread matches above, loose matches on Subject: below --
2017-09-21 23:18 [PATCH v2 0/2] " Timofey Titovets
2017-09-21 23:18 ` [PATCH v2 1/2] xxHash: create arch dependent 32/64-bit xxhash() Timofey Titovets
2017-09-25 14:59 ` Matthew Wilcox
2017-09-25 16:17 ` Timofey Titovets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922095225.343-2-nefelim4ag@gmail.com \
--to=nefelim4ag@gmail.com \
--cc=borntraeger@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox