Re: [PATCH 13/15] ceph: Use pagevec_lookup_range_nr_tag()

[Jan Kara <jack@suse.cz>]

On Mon 18-09-17 13:35:50, Yan, Zheng wrote:
> On Thu, Sep 14, 2017 at 9:18 PM, Jan Kara <jack@suse.cz> wrote:
> > Use new function for looking up pages since nr_pages argument from
> > pagevec_lookup_range_tag() is going away.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> >  fs/ceph/addr.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> > index e57e9d37bf2d..87789c477381 100644
> > --- a/fs/ceph/addr.c
> > +++ b/fs/ceph/addr.c
> > @@ -869,11 +869,9 @@ static int ceph_writepages_start(struct address_space *mapping,
> >                 max_pages = wsize >> PAGE_SHIFT;
> >
> >  get_more_pages:
> > -               pvec_pages = min_t(unsigned, PAGEVEC_SIZE,
> > -                                  max_pages - locked_pages);
> > -               pvec_pages = pagevec_lookup_range_tag(&pvec, mapping, &index,
> > +               pvec_pages = pagevec_lookup_range_nr_tag(&pvec, mapping, &index,
> >                                                 end, PAGECACHE_TAG_DIRTY,
> > -                                               pvec_pages);
> > +                                               max_pages - locked_pages);
> >                 dout("pagevec_lookup_range_tag got %d\n", pvec_pages);
> >                 if (!pvec_pages && !locked_pages)
> >                         break;
> > --
> > 2.12.3
> >
> 
> Reviewed-by: "Yan, Zheng" <zyan@redhat.com>

Thanks for the review!

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>