From: Michal Hocko <mhocko@kernel.org>
To: Kemi Wang <kemi.wang@intel.com>
Cc: "Luis R . Rodriguez" <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
Mel Gorman <mgorman@techsingularity.net>,
Johannes Weiner <hannes@cmpxchg.org>,
Christopher Lameter <cl@linux.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Vlastimil Babka <vbabka@suse.cz>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Dave <dave.hansen@linux.intel.com>,
Tim Chen <tim.c.chen@intel.com>,
Andi Kleen <andi.kleen@intel.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Ying Huang <ying.huang@intel.com>, Aaron Lu <aaron.lu@intel.com>,
Proc sysctl <linux-fsdevel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] mm: Handle numa statistics distinctively based-on different VM stats modes
Date: Fri, 15 Sep 2017 13:50:49 +0200 [thread overview]
Message-ID: <20170915115049.vqthfawg3y4r6ogh@dhcp22.suse.cz> (raw)
In-Reply-To: <1505467406-9945-3-git-send-email-kemi.wang@intel.com>
On Fri 15-09-17 17:23:25, Kemi Wang wrote:
[...]
> @@ -2743,6 +2745,17 @@ static inline void zone_statistics(struct zone *preferred_zone, struct zone *z)
> #ifdef CONFIG_NUMA
> enum numa_stat_item local_stat = NUMA_LOCAL;
>
> + /*
> + * skip zone_statistics() if vmstat is a coarse mode or zone statistics
> + * is inactive in auto vmstat mode
> + */
> +
> + if (vmstat_mode) {
> + if (vmstat_mode == VMSTAT_COARSE_MODE)
> + return;
> + } else if (disable_zone_statistics)
> + return;
> +
> if (z->node != numa_node_id())
> local_stat = NUMA_OTHER;
A jump label could make this completely out of the way for the case
where every single cycle matters.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-15 11:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 9:23 [PATCH 0/3] Handle zone statistics distinctively based-on Kemi Wang
2017-09-15 9:23 ` [PATCH 1/3] mm, sysctl: make VM stats configurable Kemi Wang
2017-09-15 11:49 ` Michal Hocko
2017-09-15 14:16 ` Dave Hansen
2017-09-15 14:28 ` Michal Hocko
2017-09-18 2:44 ` kemi
2017-09-18 5:50 ` Michal Hocko
2017-09-16 2:10 ` Wang, Kemi
2017-09-18 3:22 ` kemi
2017-09-18 5:50 ` Michal Hocko
2017-09-15 9:23 ` [PATCH 2/3] mm: Handle numa statistics distinctively based-on different VM stats modes Kemi Wang
2017-09-15 11:50 ` Michal Hocko [this message]
2017-09-18 3:07 ` kemi
2017-09-18 4:13 ` Dave Hansen
2017-09-18 5:05 ` kemi
2017-09-15 9:23 ` [PATCH 3/3] sysctl/vm.txt: Update document Kemi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915115049.vqthfawg3y4r6ogh@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=aaron.lu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi.kleen@intel.com \
--cc=bigeasy@linutronix.de \
--cc=brouer@redhat.com \
--cc=cl@linux.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=keescook@chromium.org \
--cc=kemi.wang@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=tim.c.chen@intel.com \
--cc=vbabka@suse.cz \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox