From: Michal Hocko <mhocko@kernel.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: vbabka@suse.cz, mpatocka@redhat.com, hannes@cmpxchg.org,
mgorman@suse.de, dave.hansen@intel.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: respect the __GFP_NOWARN flag when warning about stalls
Date: Wed, 13 Sep 2017 16:35:09 +0200 [thread overview]
Message-ID: <20170913143509.6wtp3pd5yhqe53ck@dhcp22.suse.cz> (raw)
In-Reply-To: <201709132314.BID39077.HMFOJSLFtVOFOQ@I-love.SAKURA.ne.jp>
On Wed 13-09-17 23:14:43, Tetsuo Handa wrote:
> Vlastimil Babka wrote:
> > On 09/13/2017 03:54 PM, Tetsuo Handa wrote:
> > > Michal Hocko wrote:
> > >> Let's see what others think about this.
> > >
> > > Whether __GFP_NOWARN should warn about stalls is not a topic to discuss.
> >
> > It is the topic of this thread, which tries to address a concrete
> > problem somebody has experienced. In that context, the rest of your
> > concerns seem to me not related to this problem, IMHO.
>
> I suggested replacing warn_alloc() with safe/useful one rather than tweaking
> warn_alloc() about __GFP_NOWARN.
What you seem to ignore is that whatever method you use for reporting
stalling allocations you would still have to consider whether to dump
a stall information for __GFP_NOWARN ones. And as the current report
shows that might be a bad idea. So please stick to the topic and do not
move it towards _what_ is the proper way of stall detection.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-09-13 14:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 6:52 Mikulas Patocka
2017-09-11 8:26 ` Michal Hocko
2017-09-11 23:36 ` Mikulas Patocka
2017-09-12 7:14 ` Vlastimil Babka
2017-09-13 14:52 ` Shakeel Butt
2017-09-13 11:54 ` Michal Hocko
2017-09-13 13:54 ` Tetsuo Handa
2017-09-13 14:03 ` Vlastimil Babka
2017-09-13 14:14 ` Tetsuo Handa
2017-09-13 14:35 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913143509.6wtp3pd5yhqe53ck@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mpatocka@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox