From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id CA2D82802FE for ; Wed, 6 Sep 2017 10:10:38 -0400 (EDT) Received: by mail-wm0-f69.google.com with SMTP id l19so6301793wmi.1 for ; Wed, 06 Sep 2017 07:10:38 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id e11si1277780wme.168.2017.09.06.07.10.37 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 06 Sep 2017 07:10:37 -0700 (PDT) Date: Wed, 6 Sep 2017 16:10:34 +0200 From: Michal Hocko Subject: Re: [v7 2/5] mm, oom: cgroup-aware OOM killer Message-ID: <20170906141034.aw2nzl577m5tt6om@dhcp22.suse.cz> References: <20170904142108.7165-1-guro@fb.com> <20170904142108.7165-3-guro@fb.com> <20170905145700.fd7jjd37xf4tb55h@dhcp22.suse.cz> <20170905202357.GA10535@castle.DHCP.thefacebook.com> <20170906083158.gvqx6pekrsy2ya47@dhcp22.suse.cz> <20170906125750.GB12904@castle> <20170906132249.c2llo5zyrzgviqzc@dhcp22.suse.cz> <20170906134142.GA15796@castle.DHCP.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170906134142.GA15796@castle.DHCP.thefacebook.com> Sender: owner-linux-mm@kvack.org List-ID: To: Roman Gushchin Cc: linux-mm@kvack.org, Vladimir Davydov , Johannes Weiner , Tetsuo Handa , David Rientjes , Andrew Morton , Tejun Heo , kernel-team@fb.com, cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org On Wed 06-09-17 14:41:42, Roman Gushchin wrote: [...] > Although, I don't think the whole thing is useful without any way > to adjust the memcg selection, so we can't postpone if for too long. > Anyway, if you think it's a way to go forward, let's do it. I am not really sure we are in a rush here. The whole oom_score_adj fiasco has showed that most users tend to only care "to never kill this and that". A better fine tuned oom control sounds useful at first but apart from very special usecases turns out very impractical to set up. At least that is my experience. There are special cases of course but we should target general use first. Kill the whole memcg is a really useful feature on its own for proper container cleanup. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org