From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f71.google.com (mail-wm0-f71.google.com [74.125.82.71]) by kanga.kvack.org (Postfix) with ESMTP id E407E28030E for ; Tue, 5 Sep 2017 03:28:39 -0400 (EDT) Received: by mail-wm0-f71.google.com with SMTP id x189so3003425wmg.5 for ; Tue, 05 Sep 2017 00:28:39 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id z97si70429wrc.232.2017.09.05.00.28.38 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 05 Sep 2017 00:28:38 -0700 (PDT) Date: Tue, 5 Sep 2017 09:28:36 +0200 From: Michal Hocko Subject: Re: [PATCH] mm, sparse: fix typo in online_mem_sections Message-ID: <20170905072836.i4dxrukevojty4ub@dhcp22.suse.cz> References: <20170904112210.3401-1-mhocko@kernel.org> <4d648f70-325d-3f60-8620-94c232b380d8@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d648f70-325d-3f60-8620-94c232b380d8@linux.vnet.ibm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Anshuman Khandual Cc: Andrew Morton , Vlastimil Babka , linux-mm@kvack.org, LKML On Tue 05-09-17 12:32:28, Anshuman Khandual wrote: > On 09/04/2017 04:52 PM, Michal Hocko wrote: > > From: Michal Hocko > > > > online_mem_sections accidentally marks online only the first section in > > the given range. This is a typo which hasn't been noticed because I > > haven't tested large 2GB blocks previously. All users of > > Section sizes are normally less than 2GB. Could you please elaborate > why this never got noticed before ? Section size is 128MB which is the default block size as well. So we have one section per block. But if the amount of memory is very large (64GB - see probe_memory_block_size) then we have a 2GB memory blocks so multiple sections per block. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org