From: Michal Hocko <mhocko@kernel.org>
To: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Cc: Kyeongdon Kim <kyeongdon.kim@lge.com>,
akpm@linux-foundation.org, sfr@canb.auug.org.au,
ying.huang@intel.com, vbabka@suse.cz, hannes@cmpxchg.org,
xieyisheng1@huawei.com, luto@kernel.org, shli@fb.com,
mgorman@techsingularity.net, hillf.zj@alibaba-inc.com,
kemi.wang@intel.com, rientjes@google.com, bigeasy@linutronix.de,
iamjoonsoo.kim@lge.com, bongkyu.kim@lge.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] mm/vmstats: add counters for the page frag cache
Date: Fri, 1 Sep 2017 11:21:08 +0200 [thread overview]
Message-ID: <20170901092108.lb3jla2hpczjvrh5@dhcp22.suse.cz> (raw)
In-Reply-To: <50592560-af4d-302c-c0bc-1e854e35139d@yandex-team.ru>
On Fri 01-09-17 12:12:36, Konstantin Khlebnikov wrote:
> IMHO that's too much counters.
> Per-node NR_FRAGMENT_PAGES should be enough for guessing what's going on.
> Perf probes provides enough features for furhter debugging.
I would tend to agree. Adding a counter based on a single debugging
instance sounds like an overkill to me. Counters should be pretty cheep
but this is way too specialized API to export to the userspace.
We have other interfaces to debug memory leaks like page_owner.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-09-01 9:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 23:37 Kyeongdon Kim
2017-08-31 23:41 ` taskboxtester
2017-08-31 23:41 ` taskboxtester
2017-09-01 9:12 ` Konstantin Khlebnikov
2017-09-01 9:21 ` Michal Hocko [this message]
2017-09-04 1:36 ` Kyeongdon Kim
2017-09-04 1:35 ` Kyeongdon Kim
2017-09-04 8:30 ` Konstantin Khlebnikov
2017-09-08 7:11 ` Kyeongdon Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170901092108.lb3jla2hpczjvrh5@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=bongkyu.kim@lge.com \
--cc=hannes@cmpxchg.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kemi.wang@intel.com \
--cc=khlebnikov@yandex-team.ru \
--cc=kyeongdon.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=shli@fb.com \
--cc=vbabka@suse.cz \
--cc=xieyisheng1@huawei.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox