From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f70.google.com (mail-oi0-f70.google.com [209.85.218.70]) by kanga.kvack.org (Postfix) with ESMTP id 1B1996B02F3 for ; Mon, 14 Aug 2017 16:29:50 -0400 (EDT) Received: by mail-oi0-f70.google.com with SMTP id g131so12228047oic.10 for ; Mon, 14 Aug 2017 13:29:50 -0700 (PDT) Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com. [2607:f8b0:4001:c06::22b]) by mx.google.com with ESMTPS id f202si5231263oig.85.2017.08.14.13.29.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Aug 2017 13:29:49 -0700 (PDT) Received: by mail-io0-x22b.google.com with SMTP id g71so42094962ioe.5 for ; Mon, 14 Aug 2017 13:29:49 -0700 (PDT) Date: Mon, 14 Aug 2017 14:29:47 -0600 From: Tycho Andersen Subject: Re: [PATCH v5 10/10] lkdtm: Add test for XPFO Message-ID: <20170814202947.er7uparyhplm77ei@smitten> References: <20170809200755.11234-1-tycho@docker.com> <20170809200755.11234-11-tycho@docker.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Kees Cook Cc: LKML , Linux-MM , "kernel-hardening@lists.openwall.com" , Marco Benatto , Juerg Haefliger On Mon, Aug 14, 2017 at 12:10:47PM -0700, Kees Cook wrote: > On Wed, Aug 9, 2017 at 1:07 PM, Tycho Andersen wrote: > > From: Juerg Haefliger > > > > This test simply reads from userspace memory via the kernel's linear > > map. > > > > hugepages is only supported on x86 right now, hence the ifdef. > > I'd prefer that the #ifdef is handled in the .c file. The result is > that all architectures will have the XPFO_READ_USER_HUGE test, but it > can just fail when not available. This means no changes are needed for > lkdtm in the future and the test provides an actual test of hugepages > coverage. If failing tests is okay, I think we can just drop that hunk entirely. Everything compiles fine, it just doesn't work :). I'll do that for the next version. Tycho -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org