From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id 44AAD6B02B4 for ; Mon, 14 Aug 2017 11:58:11 -0400 (EDT) Received: by mail-pg0-f69.google.com with SMTP id t80so142294290pgb.0 for ; Mon, 14 Aug 2017 08:58:11 -0700 (PDT) Received: from mga09.intel.com (mga09.intel.com. [134.134.136.24]) by mx.google.com with ESMTPS id s66si4271458pgc.575.2017.08.14.08.58.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Aug 2017 08:58:10 -0700 (PDT) From: "Kirill A. Shutemov" Subject: [PATCH] x86/mm: Fix personality(ADDR_NO_RANDOMIZE) Date: Mon, 14 Aug 2017 18:57:19 +0300 Message-Id: <20170814155719.74839-1-kirill.shutemov@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: Linus Torvalds , x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" Cc: Andrew Morton , Andy Lutomirski , Dmitry Safonov , Cyrill Gorcunov , Borislav Petkov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" , stable In v4.12, during rework of infrastructure around mmap_base, disable-ASLR personality flag got accidentally broken. Let's make it work again. Signed-off-by: Kirill A. Shutemov Fixes: 1b028f784e8c ("x86/mm: Introduce mmap_compat_base() for 32-bit mmap()") Cc: stable [4.12+] --- arch/x86/mm/mmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/mm/mmap.c b/arch/x86/mm/mmap.c index 229d04a83f85..779bdbe5e424 100644 --- a/arch/x86/mm/mmap.c +++ b/arch/x86/mm/mmap.c @@ -127,6 +127,8 @@ static unsigned long mmap_legacy_base(unsigned long rnd, static void arch_pick_mmap_base(unsigned long *base, unsigned long *legacy_base, unsigned long random_factor, unsigned long task_size) { + if (!(current->flags & PF_RANDOMIZE)) + random_factor = 0; *legacy_base = mmap_legacy_base(random_factor, task_size); if (mmap_is_legacy()) *base = *legacy_base; -- 2.14.1 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org