From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f197.google.com (mail-wr0-f197.google.com [209.85.128.197]) by kanga.kvack.org (Postfix) with ESMTP id 6CAE06B02F4 for ; Fri, 11 Aug 2017 12:04:40 -0400 (EDT) Received: by mail-wr0-f197.google.com with SMTP id l3so5514820wrc.12 for ; Fri, 11 Aug 2017 09:04:40 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id u20si923402wrb.323.2017.08.11.09.04.38 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 11 Aug 2017 09:04:39 -0700 (PDT) Date: Fri, 11 Aug 2017 18:04:36 +0200 From: Michal Hocko Subject: Re: [v6 04/15] mm: discard memblock data later Message-ID: <20170811160436.GS30811@dhcp22.suse.cz> References: <1502138329-123460-1-git-send-email-pasha.tatashin@oracle.com> <1502138329-123460-5-git-send-email-pasha.tatashin@oracle.com> <20170811093249.GE30811@dhcp22.suse.cz> <6366171f-1a30-2faa-d776-01983fcb5a00@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6366171f-1a30-2faa-d776-01983fcb5a00@oracle.com> Sender: owner-linux-mm@kvack.org List-ID: To: Pasha Tatashin Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com, heiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, ard.biesheuvel@linaro.org, will.deacon@arm.com, catalin.marinas@arm.com, sam@ravnborg.org, Mel Gorman On Fri 11-08-17 11:49:15, Pasha Tatashin wrote: > >I guess this goes all the way down to > >Fixes: 7e18adb4f80b ("mm: meminit: initialise remaining struct pages in parallel with kswapd") > > I will add this to the patch. > > >>Signed-off-by: Pavel Tatashin > >>Reviewed-by: Steven Sistare > >>Reviewed-by: Daniel Jordan > >>Reviewed-by: Bob Picco > > > >Considering that some HW might behave strangely and this would be rather > >hard to debug I would be tempted to mark this for stable. It should also > >be merged separately from the rest of the series. > > > >I have just one nit below > >Acked-by: Michal Hocko > > I will address your comment, and send out a new patch. Should I send it out > separately from the series or should I keep it inside? I would post it separatelly. It doesn't depend on the rest. > Also, before I send out a new patch, I will need to root cause and resolve > problem found by kernel test robot , and bisected > down to this patch. > > [ 156.659400] BUG: Bad page state in process swapper pfn:03147 > [ 156.660051] page:ffff88001ed8a1c0 count:0 mapcount:-127 mapping: > (null) index:0x1 > [ 156.660917] flags: 0x0() > [ 156.661198] raw: 0000000000000000 0000000000000000 0000000000000001 > 00000000ffffff80 > [ 156.662006] raw: ffff88001f4a8120 ffff88001ed85ce0 0000000000000000 > 0000000000000000 > [ 156.662811] page dumped because: nonzero mapcount > [ 156.663307] CPU: 0 PID: 1 Comm: swapper Not tainted > 4.13.0-rc3-00220-g1aad694 #1 > [ 156.664077] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS > 1.9.3-20161025_171302-gandalf 04/01/2014 > [ 156.665129] Call Trace: > [ 156.665422] dump_stack+0x1e/0x20 > [ 156.665802] bad_page+0x122/0x148 Was the report related with this patch? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org