From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@infradead.org>,
Huang Ying <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH v3 32/49] block: convert to singe/multi page version of bio_for_each_segment_all()
Date: Tue, 8 Aug 2017 16:45:31 +0800 [thread overview]
Message-ID: <20170808084548.18963-33-ming.lei@redhat.com> (raw)
In-Reply-To: <20170808084548.18963-1-ming.lei@redhat.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/bio.c | 17 +++++++++++------
block/blk-zoned.c | 5 +++--
block/bounce.c | 6 ++++--
3 files changed, 18 insertions(+), 10 deletions(-)
diff --git a/block/bio.c b/block/bio.c
index 716e6917b0fd..fd6a055f491c 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -997,7 +997,7 @@ int bio_alloc_pages(struct bio *bio, gfp_t gfp_mask)
int i;
struct bio_vec *bv;
- bio_for_each_segment_all(bv, bio, i) {
+ bio_for_each_segment_all_mp(bv, bio, i) {
bv->bv_page = alloc_page(gfp_mask);
if (!bv->bv_page) {
while (--bv >= bio->bi_io_vec)
@@ -1098,8 +1098,9 @@ static int bio_copy_from_iter(struct bio *bio, struct iov_iter iter)
{
int i;
struct bio_vec *bvec;
+ struct bvec_iter_all bia;
- bio_for_each_segment_all(bvec, bio, i) {
+ bio_for_each_segment_all_sp(bvec, bio, i, bia) {
ssize_t ret;
ret = copy_page_from_iter(bvec->bv_page,
@@ -1129,8 +1130,9 @@ static int bio_copy_to_iter(struct bio *bio, struct iov_iter iter)
{
int i;
struct bio_vec *bvec;
+ struct bvec_iter_all bia;
- bio_for_each_segment_all(bvec, bio, i) {
+ bio_for_each_segment_all_sp(bvec, bio, i, bia) {
ssize_t ret;
ret = copy_page_to_iter(bvec->bv_page,
@@ -1152,8 +1154,9 @@ void bio_free_pages(struct bio *bio)
{
struct bio_vec *bvec;
int i;
+ struct bvec_iter_all bia;
- bio_for_each_segment_all(bvec, bio, i)
+ bio_for_each_segment_all_sp(bvec, bio, i, bia)
__free_page(bvec->bv_page);
}
EXPORT_SYMBOL(bio_free_pages);
@@ -1444,11 +1447,12 @@ static void __bio_unmap_user(struct bio *bio)
{
struct bio_vec *bvec;
int i;
+ struct bvec_iter_all bia;
/*
* make sure we dirty pages we wrote to
*/
- bio_for_each_segment_all(bvec, bio, i) {
+ bio_for_each_segment_all_sp(bvec, bio, i, bia) {
if (bio_data_dir(bio) == READ)
set_page_dirty_lock(bvec->bv_page);
@@ -1540,8 +1544,9 @@ static void bio_copy_kern_endio_read(struct bio *bio)
char *p = bio->bi_private;
struct bio_vec *bvec;
int i;
+ struct bvec_iter_all bia;
- bio_for_each_segment_all(bvec, bio, i) {
+ bio_for_each_segment_all_sp(bvec, bio, i, bia) {
memcpy(p, page_address(bvec->bv_page), bvec->bv_len);
p += bvec->bv_len;
}
diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 3bd15d8095b1..558b84ae2d86 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -81,6 +81,7 @@ int blkdev_report_zones(struct block_device *bdev,
unsigned int ofst;
void *addr;
int ret;
+ struct bvec_iter_all bia;
if (!q)
return -ENXIO;
@@ -148,7 +149,7 @@ int blkdev_report_zones(struct block_device *bdev,
n = 0;
nz = 0;
nr_rep = 0;
- bio_for_each_segment_all(bv, bio, i) {
+ bio_for_each_segment_all_sp(bv, bio, i, bia) {
if (!bv->bv_page)
break;
@@ -181,7 +182,7 @@ int blkdev_report_zones(struct block_device *bdev,
*nr_zones = nz;
out:
- bio_for_each_segment_all(bv, bio, i)
+ bio_for_each_segment_all_sp(bv, bio, i, bia)
__free_page(bv->bv_page);
bio_put(bio);
diff --git a/block/bounce.c b/block/bounce.c
index 50e965a15295..34286abc0a66 100644
--- a/block/bounce.c
+++ b/block/bounce.c
@@ -145,11 +145,12 @@ static void bounce_end_io(struct bio *bio, mempool_t *pool)
struct bio_vec *bvec, orig_vec;
int i;
struct bvec_iter orig_iter = bio_orig->bi_iter;
+ struct bvec_iter_all bia;
/*
* free up bounce indirect pages used
*/
- bio_for_each_segment_all(bvec, bio, i) {
+ bio_for_each_segment_all_sp(bvec, bio, i, bia) {
orig_vec = bio_iter_iovec(bio_orig, orig_iter);
if (bvec->bv_page != orig_vec.bv_page) {
dec_zone_page_state(bvec->bv_page, NR_BOUNCE);
@@ -204,6 +205,7 @@ static void __blk_queue_bounce(struct request_queue *q, struct bio **bio_orig,
unsigned i = 0;
bool bounce = false;
int sectors = 0;
+ struct bvec_iter_all bia;
bio_for_each_segment(from, *bio_orig, iter) {
if (i++ < BIO_MAX_PAGES)
@@ -222,7 +224,7 @@ static void __blk_queue_bounce(struct request_queue *q, struct bio **bio_orig,
}
bio = bio_clone_bioset(*bio_orig, GFP_NOIO, bounce_bio_set);
- bio_for_each_segment_all(to, bio, i) {
+ bio_for_each_segment_all_sp(to, bio, i, bia) {
struct page *page = to->bv_page;
if (page_to_pfn(page) <= q->limits.bounce_pfn)
--
2.9.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-08-08 8:52 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 8:44 [PATCH v3 00/49] block: support multipage bvec Ming Lei
2017-08-08 8:45 ` [PATCH v3 01/49] block: drbd: comment on direct access bvec table Ming Lei
2017-08-10 11:12 ` Christoph Hellwig
2017-08-08 8:45 ` [PATCH v3 02/49] block: loop: comment on direct access to " Ming Lei
2017-08-08 8:45 ` [PATCH v3 03/49] kernel/power/swap.c: " Ming Lei
2017-08-08 8:45 ` [PATCH v3 04/49] mm: page_io.c: " Ming Lei
2017-08-10 11:14 ` Christoph Hellwig
2017-08-08 8:45 ` [PATCH v3 05/49] fs/buffer: " Ming Lei
2017-08-10 11:16 ` Christoph Hellwig
2017-08-08 8:45 ` [PATCH v3 06/49] f2fs: f2fs_read_end_io: " Ming Lei
2017-08-08 8:45 ` [PATCH v3 07/49] bcache: " Ming Lei
2017-08-08 12:36 ` Coly Li
2017-08-10 11:26 ` Christoph Hellwig
2017-10-19 22:51 ` Ming Lei
2017-08-08 8:45 ` [PATCH v3 08/49] block: comment on bio_alloc_pages() Ming Lei
2017-08-08 8:45 ` [PATCH v3 09/49] block: comment on bio_iov_iter_get_pages() Ming Lei
2017-08-10 11:28 ` Christoph Hellwig
2017-10-19 22:55 ` Ming Lei
2017-08-08 8:45 ` [PATCH v3 10/49] dm: limit the max bio size as BIO_MAX_PAGES * PAGE_SIZE Ming Lei
2017-08-10 11:29 ` Christoph Hellwig
2017-08-08 8:45 ` [PATCH v3 11/49] btrfs: avoid access to .bi_vcnt directly Ming Lei
2017-08-10 11:29 ` Christoph Hellwig
2017-10-19 22:57 ` Ming Lei
2017-08-08 8:45 ` [PATCH v3 12/49] btrfs: avoid to access bvec table directly for a cloned bio Ming Lei
2017-08-08 8:45 ` [PATCH v3 13/49] btrfs: comment on direct access bvec table Ming Lei
2017-08-08 8:45 ` [PATCH v3 14/49] block: bounce: avoid direct access to " Ming Lei
2017-08-08 8:45 ` [PATCH v3 15/49] bvec_iter: introduce BVEC_ITER_ALL_INIT Ming Lei
2017-08-08 8:45 ` [PATCH v3 16/49] block: bounce: don't access bio->bi_io_vec in copy_to_high_bio_irq Ming Lei
2017-08-08 8:45 ` [PATCH v3 17/49] block: comments on bio_for_each_segment[_all] Ming Lei
2017-08-10 11:32 ` Christoph Hellwig
2017-08-08 8:45 ` [PATCH v3 18/49] block: introduce multipage/single page bvec helpers Ming Lei
2017-08-10 12:00 ` Christoph Hellwig
2017-08-08 8:45 ` [PATCH v3 19/49] block: implement sp version of bvec iterator helpers Ming Lei
2017-08-10 12:01 ` Christoph Hellwig
2017-08-08 8:45 ` [PATCH v3 20/49] block: introduce bio_for_each_segment_mp() Ming Lei
2017-08-10 12:11 ` Christoph Hellwig
2017-10-19 23:37 ` Ming Lei
2017-08-08 8:45 ` [PATCH v3 21/49] blk-merge: compute bio->bi_seg_front_size efficiently Ming Lei
2017-08-10 12:11 ` Christoph Hellwig
2017-08-08 8:45 ` [PATCH v3 22/49] block: blk-merge: try to make front segments in full size Ming Lei
2017-08-10 12:12 ` Christoph Hellwig
2017-08-08 8:45 ` [PATCH v3 23/49] block: blk-merge: remove unnecessary check Ming Lei
2017-08-10 12:12 ` Christoph Hellwig
2017-08-08 8:45 ` [PATCH v3 24/49] block: use bio_for_each_segment_mp() to compute segments count Ming Lei
2017-08-08 8:45 ` [PATCH v3 25/49] block: use bio_for_each_segment_mp() to map sg Ming Lei
2017-08-08 8:45 ` [PATCH v3 26/49] block: introduce bvec_for_each_sp_bvec() Ming Lei
2017-08-08 8:45 ` [PATCH v3 27/49] block: bio: introduce single/multi page version of bio_for_each_segment_all() Ming Lei
2017-08-08 8:45 ` [PATCH v3 28/49] block: introduce bvec_get_last_page() Ming Lei
2017-08-08 8:45 ` [PATCH v3 29/49] fs/buffer.c: use bvec iterator to truncate the bio Ming Lei
2017-08-08 8:45 ` [PATCH v3 30/49] btrfs: use bvec_get_last_page to get bio's last page Ming Lei
2017-08-08 8:45 ` [PATCH v3 31/49] block: deal with dirtying pages for multipage bvec Ming Lei
2017-08-08 8:45 ` Ming Lei [this message]
2017-08-08 8:45 ` [PATCH v3 33/49] bcache: convert to bio_for_each_segment_all_sp() Ming Lei
2017-08-08 12:35 ` Coly Li
2017-08-08 8:45 ` [PATCH v3 34/49] md: raid1: " Ming Lei
2017-08-08 8:45 ` [PATCH v3 35/49] dm-crypt: don't clear bvec->bv_page in crypt_free_buffer_pages() Ming Lei
2017-08-08 8:45 ` [PATCH v3 36/49] dm-crypt: convert to bio_for_each_segment_all_sp() Ming Lei
2017-08-08 8:45 ` [PATCH v3 37/49] fs/mpage: " Ming Lei
2017-08-10 12:16 ` Christoph Hellwig
2017-10-19 23:58 ` Ming Lei
2017-08-08 8:45 ` [PATCH v3 38/49] fs/block: " Ming Lei
2017-08-08 8:45 ` [PATCH v3 39/49] fs/iomap: " Ming Lei
2017-08-08 8:45 ` [PATCH v3 40/49] ext4: " Ming Lei
2017-08-08 8:45 ` [PATCH v3 41/49] xfs: " Ming Lei
2017-08-08 16:32 ` Darrick J. Wong
2017-10-19 23:52 ` Ming Lei
2017-08-08 8:45 ` [PATCH v3 42/49] gfs2: " Ming Lei
2017-08-08 8:45 ` [PATCH v3 43/49] f2fs: " Ming Lei
2017-08-08 8:45 ` [PATCH v3 44/49] exofs: " Ming Lei
2017-08-08 8:45 ` [PATCH v3 45/49] fs: crypto: " Ming Lei
2017-08-08 8:45 ` [PATCH v3 46/49] fs/btrfs: " Ming Lei
2017-08-08 9:00 ` Filipe Manana
2017-08-11 16:54 ` kbuild test robot
2017-08-08 8:45 ` [PATCH v3 47/49] fs/direct-io: " Ming Lei
2017-08-08 8:45 ` [PATCH v3 48/49] block: enable multipage bvecs Ming Lei
2017-08-18 1:24 ` [lkp-robot] [block] 434f2ea20d: fileio.requests_per_sec -3.1% regression kernel test robot
2017-08-08 8:45 ` [PATCH v3 49/49] block: bio: pass segments to bio if bio_add_page() is bypassed Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170808084548.18963-33-ming.lei@redhat.com \
--to=ming.lei@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=viro@zeniv.linux.org.uk \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox