From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f71.google.com (mail-vk0-f71.google.com [209.85.213.71]) by kanga.kvack.org (Postfix) with ESMTP id E61166B025F for ; Tue, 8 Aug 2017 03:02:12 -0400 (EDT) Received: by mail-vk0-f71.google.com with SMTP id z187so9502992vkd.5 for ; Tue, 08 Aug 2017 00:02:12 -0700 (PDT) Received: from mail-ua0-x243.google.com (mail-ua0-x243.google.com. [2607:f8b0:400c:c08::243]) by mx.google.com with ESMTPS id k127si394881vke.66.2017.08.08.00.02.11 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Aug 2017 00:02:12 -0700 (PDT) Received: by mail-ua0-x243.google.com with SMTP id q25so1506878uah.0 for ; Tue, 08 Aug 2017 00:02:11 -0700 (PDT) Date: Tue, 8 Aug 2017 16:02:26 +0900 From: Sergey Senozhatsky Subject: Re: [PATCH v1 5/6] zram: remove zram_rw_page Message-ID: <20170808070226.GC7765@jagdpanzerIV.localdomain> References: <1502175024-28338-1-git-send-email-minchan@kernel.org> <1502175024-28338-6-git-send-email-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502175024-28338-6-git-send-email-minchan@kernel.org> Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ross Zwisler , "karam . lee" , seungho1.park@lge.com, Matthew Wilcox , Christoph Hellwig , Dan Williams , Dave Chinner , jack@suse.cz, Jens Axboe , Vishal Verma , linux-nvdimm@lists.01.org, kernel-team , Sergey Senozhatsky On (08/08/17 15:50), Minchan Kim wrote: > With on-stack-bio, rw_page interface doesn't provide a clear performance > benefit for zram and surely has a maintenance burden, so remove the > last user to remove rw_page completely. OK, never really liked it, I think we had that conversation before. as far as I remember, zram_rw_page() was the reason we had to do some tricks with init_lock to make lockdep happy. may be now we can "simplify" the things back. > Cc: Sergey Senozhatsky > Signed-off-by: Minchan Kim Reviewed-by: Sergey Senozhatsky -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org