linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Zi Yan <zi.yan@cs.rutgers.edu>
Cc: kbuild test robot <fengguang.wu@intel.com>,
	kbuild-all@01.org, Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Linux Memory Management List <linux-mm@kvack.org>,
	sparclinux@vger.kernel.org
Subject: Re: [mmotm:master 50/189] include/linux/swapops.h:220:9: error: implicit declaration of function '__pmd'
Date: Wed, 2 Aug 2017 07:01:23 +0200	[thread overview]
Message-ID: <20170802050123.GA23155@ravnborg.org> (raw)
In-Reply-To: <3B5D0C56-FCBC-4911-9BE8-9CA895CBE49F@cs.rutgers.edu>

Hi Yan Zin.
> 
> I saw __pmd() was deleted at commit 6e6e41879: sparc32: fix build with STRICT_MM_TYPECHECKS.
> It was commented out at least since 2008, before commit a439fe51a.
> 
> Is there any way to bring it back? Since __pmd() can help us work around a GCC zero initializer bug.

Just send a patch to sparclinux, with a proper commit message
that captures the details why it is required.

Please do not wait for me to do it, as that may take a few days
since I have not looked up all the history why it is needed.

In other words, the code change is trivial, it will more
time to explain *why* it is re-introduced.

	Sam

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2017-08-02  5:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 11:57 kbuild test robot
2017-08-01 21:38 ` Andrew Morton
2017-08-02  2:28   ` Zi Yan
2017-08-02  5:01     ` Sam Ravnborg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802050123.GA23155@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=kbuild-all@01.org \
    --cc=linux-mm@kvack.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=zi.yan@cs.rutgers.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox