linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Nadav Amit <namit@vmware.com>
To: linux-mm@kvack.org
Cc: nadav.amit@gmail.com, mgorman@suse.de, riel@redhat.com,
	luto@kernel.org, Nadav Amit <namit@vmware.com>
Subject: [PATCH v2 0/2] mm: fixes of tlb_flush_pending
Date: Wed, 26 Jul 2017 08:02:12 -0700	[thread overview]
Message-ID: <20170726150214.11320-1-namit@vmware.com> (raw)

These two patches address tlb_flush_pending issues. The first one address a
race when accessing tlb_flush_pending  and is the important one.

The second patch addresses Andrew Morton question regarding the barriers.  This
patch is not really related to the first one: the atomic operations
atomic_read() and atomic_inc() do not act as a memory barrier, and replacing
existing barriers with smp_mb__after_atomic() did not seem beneficial. Yet,
while reviewing the memory barriers around the use of tlb_flush_pending, few
issues were identified.


v1 -> v2:
 - Explain the implications of the implications of the race (Andrew)
 - Mark the patch that address the race as stable (Andrew)
 - Add another patch to clean the use of barriers (Andrew)

Nadav Amit (2):
  mm: migrate: prevent racy access to tlb_flush_pending
  mm: migrate: fix barriers around tlb_flush_pending

 include/linux/mm_types.h | 26 ++++++++++++++++----------
 kernel/fork.c            |  2 +-
 mm/debug.c               |  2 +-
 mm/migrate.c             |  9 +++++++++
 4 files changed, 27 insertions(+), 12 deletions(-)

-- 
2.11.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2017-07-26 22:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 15:02 Nadav Amit [this message]
2017-07-26 15:02 ` [PATCH v2 1/2] mm: migrate: prevent racy access to tlb_flush_pending Nadav Amit
2017-07-27  6:48   ` Mel Gorman
2017-07-29 23:50   ` kbuild test robot
2017-07-26 15:02 ` [PATCH v2 2/2] mm: migrate: fix barriers around tlb_flush_pending Nadav Amit
2017-07-27  0:04   ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726150214.11320-1-namit@vmware.com \
    --to=namit@vmware.com \
    --cc=linux-mm@kvack.org \
    --cc=luto@kernel.org \
    --cc=mgorman@suse.de \
    --cc=nadav.amit@gmail.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox