From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f197.google.com (mail-wr0-f197.google.com [209.85.128.197]) by kanga.kvack.org (Postfix) with ESMTP id 9B8EF440846 for ; Tue, 11 Jul 2017 03:22:26 -0400 (EDT) Received: by mail-wr0-f197.google.com with SMTP id z81so29568488wrc.2 for ; Tue, 11 Jul 2017 00:22:26 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id m25si9548878wrm.92.2017.07.11.00.22.25 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 11 Jul 2017 00:22:25 -0700 (PDT) Date: Tue, 11 Jul 2017 09:22:23 +0200 From: Michal Hocko Subject: Re: [RFC] mm/mremap: Remove redundant checks inside vma_expandable() Message-ID: <20170711072223.GH24852@dhcp22.suse.cz> References: <20170710111059.30795-1-khandual@linux.vnet.ibm.com> <20170710134917.GB19645@dhcp22.suse.cz> <20170711060354.GA24852@dhcp22.suse.cz> <4c182da0-6c84-df67-b173-6960fac0544a@suse.cz> <20170711065030.GE24852@dhcp22.suse.cz> <337a8a4c-1f27-7371-409d-6a9f181b3871@suse.cz> <20170711071612.GG24852@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170711071612.GG24852@dhcp22.suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: Anshuman Khandual , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com On Tue 11-07-17 09:16:12, Michal Hocko wrote: > On Tue 11-07-17 08:56:04, Vlastimil Babka wrote: [...] > > It doesn't explain why it's redundant, indeed. Unfortunately, the commit > > f106af4e90ea ("fix checks for expand-in-place mremap") which added this, > > also doesn't explain why it's needed. > > Because it doesn't do anything AFAICS. Well, it does actually. I have missed security_mmap_addr hook. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org