linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: cl@linux.com
Cc: linux-mm@kvack.org, mhocko@kernel.org
Subject: Re: mm/slab: What is cache_reap work for?
Date: Thu, 6 Jul 2017 21:48:38 +0900	[thread overview]
Message-ID: <201707062148.ADG35932.HOJOLFQMVFFStO@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <alpine.DEB.2.20.1707050906290.448@east.gentwo.org>

Christoph Lameter wrote:
> On Tue, 4 Jul 2017, Tetsuo Handa wrote:
> 
> > Thank you for explanation. What I observed is that it seems that
> > cache_reap work was not able to run because it used system_wq when
> > the system was unable to allocate memory for new worker thread due to
> > infinite too_many_isolated() loop in shrink_inactive_list().
> 
> Its ok for it not to run for awhile but that potentially traps memory. And
> you want more memory to be freed.
> 
> > I wondered whether cache_reap work qualifies as an mm_percpu_wq user
> > if cache_reap work does something like what vmstat_work work does (e.g.
> > update statistic counters which affect progress of memory allocation).
> > But "calls other functions that are used during regular slab allocation"
> > means cache_reap work cannot qualify as an mm_percpu_wq user...
> 
> Well if you audit the functions called then you may be able to get there.
> 

As far as I checked, it seems that the only operation that cache_reap work
might sleep is cond_resched(). Thus, I think that cache_reap work can
qualify as an mm_percpu_wq user.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2017-07-06 12:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-27 10:35 Tetsuo Handa
2017-06-30 13:58 ` Christoph Lameter
2017-07-04 13:15   ` Tetsuo Handa
2017-07-05 14:08     ` Christoph Lameter
2017-07-06 12:48       ` Tetsuo Handa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201707062148.ADG35932.HOJOLFQMVFFStO@I-love.SAKURA.ne.jp \
    --to=penguin-kernel@i-love.sakura.ne.jp \
    --cc=cl@linux.com \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox