From: Michal Hocko <mhocko@kernel.org>
To: zbestahu <zbestahu@aliyun.com>
Cc: akpm <akpm@linux-foundation.org>, minchan <minchan@kernel.org>,
linux-mm <linux-mm@kvack.org>, Yue Hu <huyue2@coolpad.com>,
Anton Vorontsov <anton.vorontsov@linaro.org>
Subject: Re: 回复：[PATCH] mm: vmpressure: simplify pressure ratio calculation
Date: Mon, 3 Jul 2017 17:37:16 +0200 [thread overview]
Message-ID: <20170703153716.GC11848@dhcp22.suse.cz> (raw)
In-Reply-To: <00146e00-d941-4311-8494-3e4220b04103.zbestahu@aliyun.com>
Please do not top post.
On Mon 03-07-17 22:19:02, zbestahu wrote:
> Yes, the original code using scale should be about rounding to
> integer. I am trying to improve the calculation because i think the
> rounding seems to be useless, we can calculate pressure directly just
> like original code of "pressure = pressure * 100 / scale", no
> floating number issue.From the view of disassembly, the patch is also
> better than original. If original code using scale is more powerful
> than the patch, please ignore the submit.
Make sure you describe all that in the changelog because your original
patch description wasn't all that clear about your intention.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-07-03 15:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-03 9:45 [PATCH] " zbestahu
2017-07-03 10:23 ` Michal Hocko
2017-07-03 14:19 ` 回复：[PATCH] " zbestahu
2017-07-03 15:37 ` Michal Hocko [this message]
2017-07-04 13:08 ` zbestahu
2017-07-04 13:13 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170703153716.GC11848@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anton.vorontsov@linaro.org \
--cc=huyue2@coolpad.com \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=zbestahu@aliyun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox