From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id 98B246B0292 for ; Wed, 28 Jun 2017 05:36:30 -0400 (EDT) Received: by mail-wm0-f69.google.com with SMTP id l81so2439903wmg.8 for ; Wed, 28 Jun 2017 02:36:30 -0700 (PDT) Received: from theia.8bytes.org (8bytes.org. [2a01:238:4383:600:38bc:a715:4b6d:a889]) by mx.google.com with ESMTPS id s46si886428edb.81.2017.06.28.02.36.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jun 2017 02:36:29 -0700 (PDT) Date: Wed, 28 Jun 2017 11:36:27 +0200 From: Joerg Roedel Subject: Re: [PATCH v8 RESEND 27/38] iommu/amd: Allow the AMD IOMMU to work with memory encryption Message-ID: <20170628093627.GD14532@8bytes.org> References: <20170627150718.17428.81813.stgit@tlendack-t1.amdoffice.net> <20170627151230.17428.75281.stgit@tlendack-t1.amdoffice.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170627151230.17428.75281.stgit@tlendack-t1.amdoffice.net> Sender: owner-linux-mm@kvack.org List-ID: To: Tom Lendacky Cc: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, xen-devel@lists.xen.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Brijesh Singh , Toshimitsu Kani , Radim =?utf-8?B?S3LEjW3DocWZ?= , Matt Fleming , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , Jonathan Corbet , "Michael S. Tsirkin" , Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk , Borislav Petkov , Andy Lutomirski , Boris Ostrovsky , Dmitry Vyukov , Juergen Gross , Thomas Gleixner , Paolo Bonzini Hi Tom, On Tue, Jun 27, 2017 at 10:12:30AM -0500, Tom Lendacky wrote: > --- > drivers/iommu/amd_iommu.c | 30 ++++++++++++++++-------------- > drivers/iommu/amd_iommu_init.c | 34 ++++++++++++++++++++++++++++------ > drivers/iommu/amd_iommu_proto.h | 10 ++++++++++ > drivers/iommu/amd_iommu_types.h | 2 +- > 4 files changed, 55 insertions(+), 21 deletions(-) Looks like a straightforward change. Just one nit below. > +static bool amd_iommu_supports_sme(void) > +{ > + if (!sme_active() || (boot_cpu_data.x86 != 0x17)) > + return true; > + > + /* For Fam17h, a specific level of support is required */ > + if (boot_cpu_data.microcode >= 0x08001205) > + return true; > + > + if ((boot_cpu_data.microcode >= 0x08001126) && > + (boot_cpu_data.microcode <= 0x080011ff)) > + return true; > + > + pr_notice("AMD-Vi: IOMMU not currently supported when SME is active\n"); > + > + return false; > +} The name of the function is misleading. It checks whether the IOMMU can be enabled when SME is active. But the name suggests that it checks whether the iommu hardware supports SME. How about renaming it to amd_iommu_sme_check()? With that change the patch is: Acked-by: Joerg Roedel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org