Re: [PATCH 1/1] mm: remove unused zone_type variable from __remove_zone()

[Michal Hocko <mhocko@kernel.org>]

On Fri 23-06-17 21:34:21, john.hubbard@gmail.com wrote:
> From: John Hubbard <jhubbard@nvidia.com>
> 
> __remove_zone() is setting up zone_type, but never using
> it for anything. This is not causing a warning, due to
> the (necessary) use of -Wno-unused-but-set-variable.
> However, it's noise, so just delete it.

I plan to remove the function completely FWIW but this is a trivial
impovement.
 
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  mm/memory_hotplug.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
> index 567a1dcafa1a..9bd73ecd7248 100644
> --- a/mm/memory_hotplug.c
> +++ b/mm/memory_hotplug.c
> @@ -580,11 +580,8 @@ static void __remove_zone(struct zone *zone, unsigned long start_pfn)
>  {
>  	struct pglist_data *pgdat = zone->zone_pgdat;
>  	int nr_pages = PAGES_PER_SECTION;
> -	int zone_type;
>  	unsigned long flags;
>  
> -	zone_type = zone - pgdat->node_zones;
> -
>  	pgdat_resize_lock(zone->zone_pgdat, &flags);
>  	shrink_zone_span(zone, start_pfn, start_pfn + nr_pages);
>  	shrink_pgdat_span(pgdat, start_pfn, start_pfn + nr_pages);
> -- 
> 2.13.1

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>