Re: [PATCH] mm: Remove ancient/ambiguous comment

[Michal Hocko <mhocko@suse.com>]

On Fri 23-06-17 14:35:17, Nikolay Borisov wrote:
> Currently pg_data_t is just a struct which describes a NUMA node memory 
> layout. Let's keep the comment simple and remove ambiguity.

Yes this comment just doesn't make any sense. I would even enhance the
comment and note that on UMA machines there is only a single pg_data_t
that describes the whole memory.

> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Acked-by: Michal Hocko <mhocko@suse.com>

> ---
>  include/linux/mmzone.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index ef6a13b7bd3e..c870c65fb945 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -587,10 +587,6 @@ extern struct page *mem_map;
>  #endif
>  
>  /*
> - * The pg_data_t structure is used in machines with CONFIG_DISCONTIGMEM
> - * (mostly NUMA machines?) to denote a higher-level memory zone than the
> - * zone denotes.
> - *
>   * On NUMA machines, each NUMA node would have a pg_data_t to describe
>   * it's memory layout.
>   *
> -- 
> 2.7.4

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>