From: Nicholas Piggin <npiggin@gmail.com>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, Johannes Weiner <hannes@cmpxchg.org>,
Don Zickus <dzickus@redhat.com>,
Babu Moger <babu.moger@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [mmotm:master 38/317] warning: (MN10300 && ..) selects HAVE_NMI_WATCHDOG which has unmet direct dependencies (HAVE_NMI)
Date: Sat, 17 Jun 2017 13:06:08 +1000 [thread overview]
Message-ID: <20170617130608.08f794bb@roar.ozlabs.ibm.com> (raw)
In-Reply-To: <201706170807.xkDnmZ42%fengguang.wu@intel.com>
On Sat, 17 Jun 2017 08:14:09 +0800
kbuild test robot <fengguang.wu@intel.com> wrote:
> tree: git://git.cmpxchg.org/linux-mmotm.git master
> head: 8c91e2a1ea04c0c1e29415c62f151e77de2291f8
> commit: 590b165eb905ab322bb91f04f9708deb8c80f75e [38/317] kernel/watchdog: split up config options
> config: mn10300-asb2364_defconfig (attached as .config)
> compiler: am33_2.0-linux-gcc (GCC) 6.2.0
> reproduce:
> wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 590b165eb905ab322bb91f04f9708deb8c80f75e
> # save the attached .config to linux build tree
> make.cross ARCH=mn10300
>
> All warnings (new ones prefixed by >>):
>
> warning: (MN10300 && HAVE_HARDLOCKUP_DETECTOR_ARCH) selects HAVE_NMI_WATCHDOG which has unmet direct dependencies (HAVE_NMI)
Hmm, the arch is not supposed to have HAVE_HARDLOCKUP_DETECTOR_ARCH
without explicitly selecting it. An it does not in the attached .config.
I guess this is Kconfig being helpful...
arch/Kconfig:
config HAVE_NMI_WATCHDOG
bool
help
The arch provides a low level NMI watchdog. It provides
asm/nmi.h, and defines its own arch_touch_nmi_watchdog().
config HAVE_HARDLOCKUP_DETECTOR_ARCH
bool
select HAVE_NMI_WATCHDOG
help
The arch chooses to provide its own hardlockup detector, which is
a superset of the HAVE_NMI_WATCHDOG. It also conforms to config
interfaces and parameters provided by hardlockup detector subsystem.
Idea was to have arch select HAVE_HARDLOCKUP_DETECTOR_ARCH and it would
get HAVE_NMI_WATCHDOG. Would it be better to make it depend on
HAVE_NMI_WATCHDOG and require the arch select both?
Thanks,
Nick
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-17 3:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 0:14 kbuild test robot
2017-06-17 3:06 ` Nicholas Piggin [this message]
2017-06-19 14:31 ` Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170617130608.08f794bb@roar.ozlabs.ibm.com \
--to=npiggin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=babu.moger@oracle.com \
--cc=dzickus@redhat.com \
--cc=fengguang.wu@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kbuild-all@01.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox