From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f198.google.com (mail-wr0-f198.google.com [209.85.128.198]) by kanga.kvack.org (Postfix) with ESMTP id 8E69583292 for ; Wed, 14 Jun 2017 12:24:25 -0400 (EDT) Received: by mail-wr0-f198.google.com with SMTP id n18so1512159wra.11 for ; Wed, 14 Jun 2017 09:24:25 -0700 (PDT) Received: from mail.skyhub.de (mail.skyhub.de. [5.9.137.197]) by mx.google.com with ESMTP id g51si489266wra.242.2017.06.14.09.24.24 for ; Wed, 14 Jun 2017 09:24:24 -0700 (PDT) Date: Wed, 14 Jun 2017 18:24:16 +0200 From: Borislav Petkov Subject: Re: [PATCH v6 23/34] x86, realmode: Decrypt trampoline area if memory encryption is active Message-ID: <20170614162416.ksa54esy5ql7sjgz@pd.tnic> References: <20170607191309.28645.15241.stgit@tlendack-t1.amdoffice.net> <20170607191709.28645.69034.stgit@tlendack-t1.amdoffice.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170607191709.28645.69034.stgit@tlendack-t1.amdoffice.net> Sender: owner-linux-mm@kvack.org List-ID: To: Tom Lendacky Cc: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Rik van Riel , Radim =?utf-8?B?S3LEjW3DocWZ?= , Toshimitsu Kani , Arnd Bergmann , Jonathan Corbet , Matt Fleming , "Michael S. Tsirkin" , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Larry Woodman , Brijesh Singh , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , Andrey Ryabinin , Alexander Potapenko , Dave Young , Thomas Gleixner , Dmitry Vyukov On Wed, Jun 07, 2017 at 02:17:09PM -0500, Tom Lendacky wrote: > When Secure Memory Encryption is enabled, the trampoline area must not > be encrypted. A CPU running in real mode will not be able to decrypt > memory that has been encrypted because it will not be able to use addresses > with the memory encryption mask. > > A recent change that added a new system_state value exposed a warning > issued by early_ioreamp() when the system_state was not SYSTEM_BOOTING. > At the stage where the trampoline area is decrypted, the system_state is > now SYSTEM_SCHEDULING. The check was changed to issue a warning if the > system_state is greater than or equal to SYSTEM_RUNNING. This piece along with the hunk touching system_state absolutely needs to be a separate patch as it is unrelated. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org