From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id 09DB66B0372 for ; Fri, 2 Jun 2017 17:07:47 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id 44so3357159wry.5 for ; Fri, 02 Jun 2017 14:07:46 -0700 (PDT) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org. [140.211.169.12]) by mx.google.com with ESMTPS id s13si12668387wrb.195.2017.06.02.14.07.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Jun 2017 14:07:45 -0700 (PDT) Date: Fri, 2 Jun 2017 14:07:43 -0700 From: Andrew Morton Subject: Re: [PATCH v4] add the option of fortified string.h functions Message-Id: <20170602140743.274b9babba6118bfd12c7a26@linux-foundation.org> In-Reply-To: <20170526095404.20439-1-danielmicay@gmail.com> References: <20170526095404.20439-1-danielmicay@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Daniel Micay Cc: linux-mm@kvack.org, Kees Cook , kernel-hardening@lists.openwall.com, linux-kernel , Mark Rutland , Daniel Axtens , Moni Shoua , Doug Ledford , Sean Hefty , Hal Rosenstock , linux-rdma@vger.kernel.org On Fri, 26 May 2017 05:54:04 -0400 Daniel Micay wrote: > This adds support for compiling with a rough equivalent to the glibc > _FORTIFY_SOURCE=1 feature, providing compile-time and runtime buffer > overflow checks for string.h functions when the compiler determines the > size of the source or destination buffer at compile-time. Unlike glibc, > it covers buffer reads in addition to writes. Did we find a bug in drivers/infiniband/sw/rxe/rxe_resp.c? i386 allmodconfig: In file included from ./include/linux/bitmap.h:8:0, from ./include/linux/cpumask.h:11, from ./include/linux/mm_types_task.h:13, from ./include/linux/mm_types.h:4, from ./include/linux/kmemcheck.h:4, from ./include/linux/skbuff.h:18, from drivers/infiniband/sw/rxe/rxe_resp.c:34: In function 'memcpy', inlined from 'send_atomic_ack.constprop' at drivers/infiniband/sw/rxe/rxe_resp.c:998:2, inlined from 'acknowledge' at drivers/infiniband/sw/rxe/rxe_resp.c:1026:3, inlined from 'rxe_responder' at drivers/infiniband/sw/rxe/rxe_resp.c:1286:10: ./include/linux/string.h:309:4: error: call to '__read_overflow2' declared with attribute error: detected read beyond size of object passed as 2nd parameter __read_overflow2(); If so, can you please interpret this for the infiniband developers? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org