From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f197.google.com (mail-wr0-f197.google.com [209.85.128.197]) by kanga.kvack.org (Postfix) with ESMTP id 627B66B02B4 for ; Tue, 30 May 2017 10:55:16 -0400 (EDT) Received: by mail-wr0-f197.google.com with SMTP id 6so7034891wrb.15 for ; Tue, 30 May 2017 07:55:16 -0700 (PDT) Received: from mail.skyhub.de (mail.skyhub.de. [2a01:4f8:190:11c2::b:1457]) by mx.google.com with ESMTP id n188si25921470wmf.156.2017.05.30.07.55.14 for ; Tue, 30 May 2017 07:55:15 -0700 (PDT) Date: Tue, 30 May 2017 16:55:00 +0200 From: Borislav Petkov Subject: Re: [PATCH v5 32/32] x86/mm: Add support to make use of Secure Memory Encryption Message-ID: <20170530145459.tyuy6veqxnrqkhgw@pd.tnic> References: <20170418211612.10190.82788.stgit@tlendack-t1.amdoffice.net> <20170418212223.10190.85121.stgit@tlendack-t1.amdoffice.net> <20170519112703.voajtn4t7uy6nwa3@pd.tnic> <7c522f65-c5c8-9362-e1eb-d0765e3ea6c9@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7c522f65-c5c8-9362-e1eb-d0765e3ea6c9@amd.com> Sender: owner-linux-mm@kvack.org List-ID: To: Tom Lendacky Cc: linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, linux-doc@vger.kernel.org, x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Rik van Riel , Radim =?utf-8?B?S3LEjW3DocWZ?= , Toshimitsu Kani , Arnd Bergmann , Jonathan Corbet , Matt Fleming , "Michael S. Tsirkin" , Joerg Roedel , Konrad Rzeszutek Wilk , Paolo Bonzini , Larry Woodman , Brijesh Singh , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , Andrey Ryabinin , Alexander Potapenko , Dave Young , Thomas Gleixner , Dmitry Vyukov On Tue, May 30, 2017 at 09:38:36AM -0500, Tom Lendacky wrote: > In this case we're running identity mapped and the "on" constant ends up > as kernel address (0xffffffff81...) which results in a segfault. Would static const char *__on_str = "on"; ... if (!strncmp(buffer, __pa_nodebug(__on_str), 2)) ... work? __phys_addr_nodebug() seems to pay attention to phys_base and PAGE_OFFSET and so on... I'd like to avoid that rip-relative address finding in inline asm which looks fragile to me. Thanks. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org