From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id 6B1D96B0279 for ; Fri, 26 May 2017 13:19:07 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id g67so1330515wrd.0 for ; Fri, 26 May 2017 10:19:07 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id y30si2102211edy.113.2017.05.26.10.19.05 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 26 May 2017 10:19:06 -0700 (PDT) Date: Fri, 26 May 2017 18:19:03 +0100 From: Luis Henriques Subject: Re: [PATCH v2 2/3] mm: kmemleak: Factor object reference updating out of scan_block() Message-ID: <20170526171903.5q3e5vqbhzcymdcd@hermes.olymp> References: <1495726937-23557-1-git-send-email-catalin.marinas@arm.com> <1495726937-23557-3-git-send-email-catalin.marinas@arm.com> <20170526160916.ptlc2huao3bn4qwq@hermes.olymp> <20170526162107.GC30853@e104818-lin.cambridge.arm.com> <20170526162329.GD30853@e104818-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170526162329.GD30853@e104818-lin.cambridge.arm.com> Sender: owner-linux-mm@kvack.org List-ID: To: Catalin Marinas Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko , Andy Lutomirski , "Luis R. Rodriguez" , Andrew Morton On Fri, May 26, 2017 at 05:23:30PM +0100, Catalin Marinas wrote: > On Fri, May 26, 2017 at 05:21:08PM +0100, Catalin Marinas wrote: > > On Fri, May 26, 2017 at 05:09:17PM +0100, Luis Henriques wrote: > > > On Thu, May 25, 2017 at 04:42:16PM +0100, Catalin Marinas wrote: > > > > The scan_block() function updates the number of references (pointers) to > > > > objects, adding them to the gray_list when object->min_count is reached. > > > > The patch factors out this functionality into a separate update_refs() > > > > function. > > > > > > > > Cc: Michal Hocko > > > > Cc: Andy Lutomirski > > > > Cc: "Luis R. Rodriguez" > > > > Signed-off-by: Catalin Marinas > [...] > > > FWIW, I've tested this patchset and I don't see kmemleak triggering the > > > false positives anymore. > > > > Thanks for re-testing (I dropped your tested-by from the initial patch > > since I made a small modification). > > Sorry, the "re-testing" comment was meant at the other Luis on cc ;) > (Luis R. Rodriguez). It's been a long day... Heh, no worries! What are the odds of having 2 different guys named Luis testing the same patch? :-) Cheers, -- Luis -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org