From: Andrew Morton <akpm@linux-foundation.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: David Rientjes <rientjes@google.com>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Mark Brown <broonie@kernel.org>, Ingo Molnar <mingo@kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [patch] compiler, clang: suppress warning for unused static inline functions
Date: Wed, 24 May 2017 14:32:05 -0700 [thread overview]
Message-ID: <20170524143205.cae1a02ab2ad7348c1a59e0c@linux-foundation.org> (raw)
In-Reply-To: <20170524212229.GR141096@google.com>
On Wed, 24 May 2017 14:22:29 -0700 Matthias Kaehlcke <mka@chromium.org> wrote:
> I'm not a kernel maintainer, so it's not my decision whether this
> warning should be silenced, my personal opinion is that it's benfits
> outweigh the inconveniences of dealing with half-false positives,
> generally caused by the heavy use of #ifdef by the kernel itself.
Please resend and include this info in the changelog. Describe
instances where this warning has resulted in actual runtime or
developer-visible benefits.
Where possible an appropriate I suggest it is better to move the
offending function into a header file, rather than adding ifdefs.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-05-24 21:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 21:01 David Rientjes
2017-05-24 21:22 ` Matthias Kaehlcke
2017-05-24 21:32 ` Andrew Morton [this message]
2017-05-24 23:28 ` Doug Anderson
2017-05-31 0:10 ` David Rientjes
2017-05-31 1:53 ` Matthias Kaehlcke
2017-05-31 15:53 ` Doug Anderson
2017-05-31 18:26 ` Mark Brown
2017-05-31 21:45 ` David Rientjes
2017-05-31 22:31 ` Doug Anderson
2017-06-01 0:01 ` Matthias Kaehlcke
2017-05-25 5:52 ` Ingo Molnar
2017-05-25 16:14 ` Matthias Kaehlcke
2017-05-25 16:48 ` Joe Perches
2017-05-25 17:49 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170524143205.cae1a02ab2ad7348c1a59e0c@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=dianders@chromium.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@kernel.org \
--cc=mka@chromium.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox