From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f69.google.com (mail-wm0-f69.google.com [74.125.82.69]) by kanga.kvack.org (Postfix) with ESMTP id E4D336B0338 for ; Wed, 24 May 2017 08:03:22 -0400 (EDT) Received: by mail-wm0-f69.google.com with SMTP id g143so38060212wme.13 for ; Wed, 24 May 2017 05:03:22 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id q33si21557529edd.116.2017.05.24.05.03.21 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 24 May 2017 05:03:21 -0700 (PDT) Date: Wed, 24 May 2017 14:03:18 +0200 From: Michal Hocko Subject: Re: [PATCH 0/6] refine and rename slub sysfs Message-ID: <20170524120318.GE14733@dhcp22.suse.cz> References: <20170517141146.11063-1-richard.weiyang@gmail.com> <20170518090636.GA25471@dhcp22.suse.cz> <20170523032705.GA4275@WeideMBP.lan> <20170523063911.GC12813@dhcp22.suse.cz> <20170524095450.GA7706@WeideMBP.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170524095450.GA7706@WeideMBP.lan> Sender: owner-linux-mm@kvack.org List-ID: To: Wei Yang Cc: cl@linux.com, penberg@kernel.org, rientjes@google.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Wed 24-05-17 17:54:50, Wei Yang wrote: > On Tue, May 23, 2017 at 08:39:11AM +0200, Michal Hocko wrote: [...] > >Is this worth risking breakage of the userspace which consume this data > >now? Do you have any user space code which will greatly benefit from the > >new data and which couldn't do the same with the current format/output? > > > >If yes this all should be in the changelog. > > The answer is no. > > I have the same concern as yours. So this patch set could be divided into two > parts: 1. add some new entry with current name convention, 2. change the name > convention. Who is going to use those new entries and for what purpose? Why do we want to expose even more details of the slab allocator to the userspace. Is the missing information something fundamental that some user space cannot work without it? Seriously these are essential questions you should have answer for _before_ posting the patch and mention all those reasons in the changelog. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org