linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Correct spelling and grammar for notification text
@ 2017-05-17 13:38 Michael DeGuzis
  2017-05-17 15:35 ` Randy Dunlap
  0 siblings, 1 reply; 3+ messages in thread
From: Michael DeGuzis @ 2017-05-17 13:38 UTC (permalink / raw)
  To: linux-mm; +Cc: trivial, professorkaos64

From: professorkaos64 <mdeguzis@gmail.com>

This patch fixes up some grammar and spelling in the information
block for huge_memory.c.
---
 mm/huge_memory.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index a84909cf20d3..af137fc0ca09 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -38,12 +38,12 @@
 #include "internal.h"
 
 /*
- * By default transparent hugepage support is disabled in order that avoid
- * to risk increase the memory footprint of applications without a guaranteed
- * benefit. When transparent hugepage support is enabled, is for all mappings,
- * and khugepaged scans all mappings.
+ * By default, transparent hugepage support is disabled in order to avoid
+ * risking an increased memory footprint for applications that are not 
+ * guaranteed to benefit from it. When transparent hugepage support is 
+ * enabled, it is for all mappings, and khugepaged scans all mappings.
  * Defrag is invoked by khugepaged hugepage allocations and by page faults
- * for all hugepage allocations.
+ * for all hugepage allocations. 
  */
 unsigned long transparent_hugepage_flags __read_mostly =
 #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS
-- 
2.12.2

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Correct spelling and grammar for notification text
  2017-05-17 13:38 [PATCH] Correct spelling and grammar for notification text Michael DeGuzis
@ 2017-05-17 15:35 ` Randy Dunlap
  2017-05-17 17:23   ` mikey d
  0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2017-05-17 15:35 UTC (permalink / raw)
  To: Michael DeGuzis, linux-mm; +Cc: trivial

On 05/17/17 06:38, Michael DeGuzis wrote:
> From: professorkaos64 <mdeguzis@gmail.com>
> 
> This patch fixes up some grammar and spelling in the information
> block for huge_memory.c.

Missing Signed-off-by: <real name and email address>

> ---
>  mm/huge_memory.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> index a84909cf20d3..af137fc0ca09 100644
> --- a/mm/huge_memory.c
> +++ b/mm/huge_memory.c
> @@ -38,12 +38,12 @@
>  #include "internal.h"
>  
>  /*
> - * By default transparent hugepage support is disabled in order that avoid
> - * to risk increase the memory footprint of applications without a guaranteed
> - * benefit. When transparent hugepage support is enabled, is for all mappings,
> - * and khugepaged scans all mappings.
> + * By default, transparent hugepage support is disabled in order to avoid
> + * risking an increased memory footprint for applications that are not 
> + * guaranteed to benefit from it. When transparent hugepage support is 
> + * enabled, it is for all mappings, and khugepaged scans all mappings.
>   * Defrag is invoked by khugepaged hugepage allocations and by page faults
> - * for all hugepage allocations.
> + * for all hugepage allocations. 

Several of the new (+) patch lines end with a space character. Not good.

>   */
>  unsigned long transparent_hugepage_flags __read_mostly =
>  #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS
> 


-- 
~Randy

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Correct spelling and grammar for notification text
  2017-05-17 15:35 ` Randy Dunlap
@ 2017-05-17 17:23   ` mikey d
  0 siblings, 0 replies; 3+ messages in thread
From: mikey d @ 2017-05-17 17:23 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: linux-mm, trivial

[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]

V2 incoming soon. My first patch :)

On May 17, 2017 11:35, "Randy Dunlap" <rdunlap@infradead.org> wrote:

> On 05/17/17 06:38, Michael DeGuzis wrote:
> > From: professorkaos64 <mdeguzis@gmail.com>
> >
> > This patch fixes up some grammar and spelling in the information
> > block for huge_memory.c.
>
> Missing Signed-off-by: <real name and email address>
>
> > ---
> >  mm/huge_memory.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> > index a84909cf20d3..af137fc0ca09 100644
> > --- a/mm/huge_memory.c
> > +++ b/mm/huge_memory.c
> > @@ -38,12 +38,12 @@
> >  #include "internal.h"
> >
> >  /*
> > - * By default transparent hugepage support is disabled in order that
> avoid
> > - * to risk increase the memory footprint of applications without a
> guaranteed
> > - * benefit. When transparent hugepage support is enabled, is for all
> mappings,
> > - * and khugepaged scans all mappings.
> > + * By default, transparent hugepage support is disabled in order to
> avoid
> > + * risking an increased memory footprint for applications that are not
> > + * guaranteed to benefit from it. When transparent hugepage support is
> > + * enabled, it is for all mappings, and khugepaged scans all mappings.
> >   * Defrag is invoked by khugepaged hugepage allocations and by page
> faults
> > - * for all hugepage allocations.
> > + * for all hugepage allocations.
>
> Several of the new (+) patch lines end with a space character. Not good.
>
> >   */
> >  unsigned long transparent_hugepage_flags __read_mostly =
> >  #ifdef CONFIG_TRANSPARENT_HUGEPAGE_ALWAYS
> >
>
>
> --
> ~Randy
>

[-- Attachment #2: Type: text/html, Size: 2235 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-05-17 17:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-17 13:38 [PATCH] Correct spelling and grammar for notification text Michael DeGuzis
2017-05-17 15:35 ` Randy Dunlap
2017-05-17 17:23   ` mikey d

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox