From: Michal Hocko <mhocko@kernel.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, Daniel Vetter <daniel.vetter@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
Sean Paul <seanpaul@chromium.org>,
David Airlie <airlied@linux.ie>
Subject: Re: [PATCH] drm: use kvmalloc_array for drm_malloc*
Date: Tue, 16 May 2017 11:52:55 +0200 [thread overview]
Message-ID: <20170516095254.GG2481@dhcp22.suse.cz> (raw)
In-Reply-To: <20170516092230.pzadndxm5gq4i4h6@phenom.ffwll.local>
On Tue 16-05-17 11:22:30, Daniel Vetter wrote:
> On Tue, May 16, 2017 at 11:06:06AM +0200, Michal Hocko wrote:
> > From: Michal Hocko <mhocko@suse.com>
> >
> > drm_malloc* has grown their own kmalloc with vmalloc fallback
> > implementations. MM has grown kvmalloc* helpers in the meantime. Let's
> > use those because it a) reduces the code and b) MM has a better idea
> > how to implement fallbacks (e.g. do not vmalloc before kmalloc is tried
> > with __GFP_NORETRY).
> >
> > Signed-off-by: Michal Hocko <mhocko@suse.com>
>
> Shouldn't we go one step further and just remove these wrappers, maybe
> with cocci?
my cocci sucks...
> Especially drm_malloc_gfp is surpremely pointless after this
> patch (and drm_malloc_ab probably not that useful either).
So what about the following instead? It passes allyesconfig compilation.
---
next prev parent reply other threads:[~2017-05-16 9:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 9:06 Michal Hocko
2017-05-16 9:22 ` Daniel Vetter
2017-05-16 9:52 ` Michal Hocko [this message]
2017-05-16 13:08 ` Daniel Vetter
2017-05-16 13:21 ` Michal Hocko
2017-05-16 9:31 ` Chris Wilson
2017-05-16 10:53 ` Michal Hocko
2017-05-16 11:09 ` Chris Wilson
2017-05-17 7:44 ` Michal Hocko
2017-05-17 7:59 ` Chris Wilson
2017-05-17 8:09 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516095254.GG2481@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox