From: Michal Hocko <mhocko@kernel.org>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com,
cgroups@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 0/2] mm/memcontrol: fix reclaim bugs in mem_cgroup_iter
Date: Tue, 2 May 2017 16:03:57 +0200 [thread overview]
Message-ID: <20170502140357.GL14593@dhcp22.suse.cz> (raw)
In-Reply-To: <1493416547-19212-1-git-send-email-sean.j.christopherson@intel.com>
On Fri 28-04-17 14:55:45, Sean Christopherson wrote:
> This patch set contains two bug fixes for mem_cgroup_iter(). The bugs
> were found by code inspection and were confirmed via synthetic testing
> that forcefully setup the failing conditions.
I assume that you added some artificial sleeps to make those races more
probable, right? Or did you manage to hit those issue solely from the
userspace? I will have a look at those patches. It has been some time
since I've had it cached. It is pretty subtle code so I would like to
understand the urgency before I dive into this further.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-05-02 14:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 21:55 Sean Christopherson
2017-04-28 21:55 ` [PATCH 1/2] mm/memcontrol: check cmpxchg(iter->pos...) result in mem_cgroup_iter() Sean Christopherson
2017-04-28 21:55 ` [PATCH 2/2] mm/memcontrol: inc reclaim gen if restarting walk " Sean Christopherson
2017-05-02 14:03 ` Michal Hocko [this message]
2017-05-02 14:20 ` [PATCH 0/2] mm/memcontrol: fix reclaim bugs in mem_cgroup_iter Christopherson, Sean J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502140357.GL14593@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=sean.j.christopherson@intel.com \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox