From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id 54F306B0338 for ; Mon, 24 Apr 2017 11:57:59 -0400 (EDT) Received: by mail-pg0-f69.google.com with SMTP id s1so15571534pgc.22 for ; Mon, 24 Apr 2017 08:57:59 -0700 (PDT) Received: from mx1.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id a5si19465257plt.253.2017.04.24.08.57.58 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 24 Apr 2017 08:57:58 -0700 (PDT) Date: Mon, 24 Apr 2017 17:57:55 +0200 From: Jan Kara Subject: Re: [PATCH v3 09/20] 9p: set mapping error when writeback fails in launder_page Message-ID: <20170424155755.GJ23988@quack2.suse.cz> References: <20170424132259.8680-1-jlayton@redhat.com> <20170424132259.8680-10-jlayton@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170424132259.8680-10-jlayton@redhat.com> Sender: owner-linux-mm@kvack.org List-ID: To: Jeff Layton Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org, jfs-discussion@lists.sourceforge.net, linux-xfs@vger.kernel.org, cluster-devel@redhat.com, linux-f2fs-devel@lists.sourceforge.net, v9fs-developer@lists.sourceforge.net, osd-dev@open-osd.org, linux-nilfs@vger.kernel.org, linux-block@vger.kernel.org, dhowells@redhat.com, akpm@linux-foundation.org, hch@infradead.org, ross.zwisler@linux.intel.com, mawilcox@microsoft.com, jack@suse.com, viro@zeniv.linux.org.uk, corbet@lwn.net, neilb@suse.de, clm@fb.com, tytso@mit.edu, axboe@kernel.dk On Mon 24-04-17 09:22:48, Jeff Layton wrote: > launder_page is just writeback under the page lock. We still need to > mark the mapping for errors there when they occur. > > Signed-off-by: Jeff Layton Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > fs/9p/vfs_addr.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/9p/vfs_addr.c b/fs/9p/vfs_addr.c > index adaf6f6dd858..7af6e6501698 100644 > --- a/fs/9p/vfs_addr.c > +++ b/fs/9p/vfs_addr.c > @@ -223,8 +223,11 @@ static int v9fs_launder_page(struct page *page) > v9fs_fscache_wait_on_page_write(inode, page); > if (clear_page_dirty_for_io(page)) { > retval = v9fs_vfs_writepage_locked(page); > - if (retval) > + if (retval) { > + if (retval != -EAGAIN) > + mapping_set_error(page->mapping, retval); > return retval; > + } > } > return 0; > } > -- > 2.9.3 > > -- Jan Kara SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org