From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f69.google.com (mail-oi0-f69.google.com [209.85.218.69]) by kanga.kvack.org (Postfix) with ESMTP id 46E1B6B03A3 for ; Thu, 13 Apr 2017 12:17:22 -0400 (EDT) Received: by mail-oi0-f69.google.com with SMTP id b187so47053700oif.11 for ; Thu, 13 Apr 2017 09:17:22 -0700 (PDT) Received: from merlin.infradead.org (merlin.infradead.org. [2001:4978:20e::2]) by mx.google.com with ESMTPS id e194si10704437oib.0.2017.04.13.09.17.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Apr 2017 09:17:21 -0700 (PDT) Date: Thu, 13 Apr 2017 18:17:09 +0200 From: Peter Zijlstra Subject: Re: [PATCH tip/core/rcu 01/13] mm: Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU Message-ID: <20170413161709.ej3qxuqitykhqtyf@hirez.programming.kicks-ass.net> References: <20170412165441.GA17149@linux.vnet.ibm.com> <1492016149-18834-1-git-send-email-paulmck@linux.vnet.ibm.com> <20170413091248.xnctlppstkrm6eq5@hirez.programming.kicks-ass.net> <50d59b9c-fa8e-1992-2613-e84774ec5428@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50d59b9c-fa8e-1992-2613-e84774ec5428@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: To: Vlastimil Babka Cc: "Paul E. McKenney" , linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , linux-mm@kvack.org On Thu, Apr 13, 2017 at 01:06:56PM +0200, Vlastimil Babka wrote: > On 04/13/2017 11:12 AM, Peter Zijlstra wrote: > > On Wed, Apr 12, 2017 at 09:55:37AM -0700, Paul E. McKenney wrote: > >> A group of Linux kernel hackers reported chasing a bug that resulted > >> from their assumption that SLAB_DESTROY_BY_RCU provided an existence > >> guarantee, that is, that no block from such a slab would be reallocated > >> during an RCU read-side critical section. Of course, that is not the > >> case. Instead, SLAB_DESTROY_BY_RCU only prevents freeing of an entire > >> slab of blocks. > > > > And that while we wrote a huge honking comment right along with it... > > > >> [ paulmck: Add "tombstone" comments as requested by Eric Dumazet. ] > > > > I cannot find any occurrence of "tomb" or "TOMB" in the actual patch, > > confused? > > It's the comments such as: > > + * Note that SLAB_TYPESAFE_BY_RCU was originally named SLAB_DESTROY_BY_RCU. > > so that people who remember the old name can git grep its fate. git log -S SLAB_DESTROY_BY_RCU -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org