From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f70.google.com (mail-wm0-f70.google.com [74.125.82.70]) by kanga.kvack.org (Postfix) with ESMTP id 5DD286B0038 for ; Wed, 12 Apr 2017 08:30:45 -0400 (EDT) Received: by mail-wm0-f70.google.com with SMTP id b124so1372778wmf.6 for ; Wed, 12 Apr 2017 05:30:45 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id o39si30905704wrb.225.2017.04.12.05.30.43 for (version=TLS1 cipher=AES128-SHA bits=128/128); Wed, 12 Apr 2017 05:30:43 -0700 (PDT) Date: Wed, 12 Apr 2017 14:30:42 +0200 From: Michal Hocko Subject: Re: [PATCH] mm, page_alloc: Remove debug_guardpage_minorder() test in warn_alloc(). Message-ID: <20170412123042.GF7157@dhcp22.suse.cz> References: <20170412102341.GA13958@redhat.com> <20170412105951.GB7157@dhcp22.suse.cz> <20170412112154.GB14892@redhat.com> <20170412113528.GC7157@dhcp22.suse.cz> <20170412114754.GA15135@redhat.com> <201704122114.JDG73963.SFFLVQOOtMJHFO@I-love.SAKURA.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201704122114.JDG73963.SFFLVQOOtMJHFO@I-love.SAKURA.ne.jp> Sender: owner-linux-mm@kvack.org List-ID: To: Tetsuo Handa Cc: sgruszka@redhat.com, akpm@linux-foundation.org, linux-mm@kvack.org, rjw@sisk.pl, aarcange@redhat.com, cl@linux-foundation.org, mgorman@suse.de, penberg@cs.helsinki.fi On Wed 12-04-17 21:14:10, Tetsuo Handa wrote: > Stanislaw Gruszka wrote: > > On Wed, Apr 12, 2017 at 01:35:28PM +0200, Michal Hocko wrote: > > > OK, I see. That is a rather weird feature and the naming is more than > > > surprising. But put that aside. Then it means that the check should be > > > pulled out to > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > > index 6632256ef170..1e5f3b5cdb87 100644 > > > --- a/mm/page_alloc.c > > > +++ b/mm/page_alloc.c > > > @@ -3941,7 +3941,8 @@ __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > > > goto retry; > > > } > > > fail: > > > - warn_alloc(gfp_mask, ac->nodemask, > > > + if (!debug_guardpage_minorder()) > > > + warn_alloc(gfp_mask, ac->nodemask, > > > "page allocation failure: order:%u", order); > > > got_pg: > > > return page; > > > > Looks good to me assuming it will be applied on top of Tetsuo's patch. > > > > Reviewed-by: Stanislaw Gruszka > > > > There are two warn_alloc() usages in mm/vmalloc.c which the check should be > pulled out. Do we actually care about vmalloc for this? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org