From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f200.google.com (mail-qk0-f200.google.com [209.85.220.200]) by kanga.kvack.org (Postfix) with ESMTP id 1E0DD6B039F for ; Wed, 5 Apr 2017 05:07:03 -0400 (EDT) Received: by mail-qk0-f200.google.com with SMTP id p22so1892768qka.4 for ; Wed, 05 Apr 2017 02:07:03 -0700 (PDT) Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id n89si17312714qte.325.2017.04.05.02.07.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 02:07:02 -0700 (PDT) Date: Wed, 5 Apr 2017 11:06:54 +0200 From: Igor Mammedov Subject: Re: [PATCH v1 1/6] mm: get rid of zone_is_initialized Message-ID: <20170405110654.6ef458ee@nial.brq.redhat.com> In-Reply-To: <20170405081400.GE6035@dhcp22.suse.cz> References: <20170330115454.32154-1-mhocko@kernel.org> <20170330115454.32154-2-mhocko@kernel.org> <20170331073954.GF27098@dhcp22.suse.cz> <20170405081400.GE6035@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Reza Arbab , Yasuaki Ishimatsu , Tang Chen , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , David Rientjes , Daniel Kiper , Vitaly Kuznetsov , LKML On Wed, 5 Apr 2017 10:14:00 +0200 Michal Hocko wrote: > On Fri 31-03-17 09:39:54, Michal Hocko wrote: > > Fixed screw ups during the initial patch split up as per Hillf > > --- > > From 8be6c5e47de66210e47710c80e72e8abd899017b Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Wed, 29 Mar 2017 15:11:30 +0200 > > Subject: [PATCH] mm: get rid of zone_is_initialized > > > > There shouldn't be any reason to add initialized when we can tell the > > same thing from checking whether there are any pages spanned to the > > zone. Remove zone_is_initialized() and replace it by zone_is_empty > > which can be used for the same set of tests. > > > > This shouldn't have any visible effect > > I've decided to drop this patch. My main motivation was to simplify > the hotplug workflow/ The situation is more hairy than I expected, > though. On one hand all zones should be initialized early during the > hotplug in add_memory_resource but direct users of arch_add_memory will > need this to be called I suspect. Let's just keep the current status quo > and clean up it later. It is not really needed for this series. Would you post v2 with all fixups you've done so far? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org