From: Andrea Arcangeli <aarcange@redhat.com>
To: Alexey Perevalov <a.perevalov@samsung.com>
Cc: linux-mm@kvack.org, rppt@linux.vnet.ibm.com,
mike.kravetz@oracle.com, dgilbert@redhat.com
Subject: Re: [PATCH v3] userfaultfd: provide pid in userfault msg
Date: Tue, 4 Apr 2017 21:04:19 +0200 [thread overview]
Message-ID: <20170404190419.GA5081@redhat.com> (raw)
In-Reply-To: <1491211956-6095-2-git-send-email-a.perevalov@samsung.com>
Hello Alexey,
v3 looks great to me.
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
On top of v3 I think we could add this to make it more obvious to the
developer tpid isn't necessarily there by just looking at the data
structure.
This is purely cosmetical, so feel free to comment if you
disagree.
I'm also fine to add an anonymous union later if a new usage for those
bytes emerges (ABI side doesn't change anything which is why this
could be done later as well, only the API changes here but then I
doubt we'd break the API later for this, so if we want pagefault.feat.*
it probably should be done right now).
Thanks,
Andrea
next prev parent reply other threads:[~2017-04-04 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170403093307eucas1p2e1110dd2550426c53a7b8825efa34f99@eucas1p2.samsung.com>
2017-04-03 9:32 ` [PATCH v3] Illuminate thread id to user space Alexey Perevalov
[not found] ` <CGME20170403093318eucas1p2ebd57e5e4c33707063687ccd571f67bb@eucas1p2.samsung.com>
2017-04-03 9:32 ` [PATCH v3] userfaultfd: provide pid in userfault msg Alexey Perevalov
2017-04-04 19:04 ` Andrea Arcangeli [this message]
2017-04-05 12:42 ` Alexey Perevalov
2017-04-03 9:38 ` [PATCH v3] please don't see patch set Alexey Perevalov
2017-04-03 9:42 ` Alexey Perevalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404190419.GA5081@redhat.com \
--to=aarcange@redhat.com \
--cc=a.perevalov@samsung.com \
--cc=dgilbert@redhat.com \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox