From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Polakov <apolyakov@beget.ru>, linux-mm@kvack.org
Subject: Re: [PATCH] Fix print order in show_free_areas()
Date: Tue, 4 Apr 2017 15:19:07 +0100 [thread overview]
Message-ID: <20170404141907.eomyynht4vlhu2ni@techsingularity.net> (raw)
In-Reply-To: <20170403151111.4c9967329d6d6140e2a652ff@linux-foundation.org>
On Mon, Apr 03, 2017 at 03:11:11PM -0700, Andrew Morton wrote:
> On Fri, 24 Mar 2017 20:48:50 +0300 Alexander Polakov <apolyakov@beget.ru> wrote:
>
> > Better seen in context: https://github.com/torvalds/linux/blob/master/m
> > m/page_alloc.c#L4500
> >
> > Signed-off-by: Alexander Polyakov <apolyakov@beget.com>
>
> --- a/mm/page_alloc.c~fix-print-order-in-show_free_areas
> +++ a/mm/page_alloc.c
> @@ -4519,13 +4519,13 @@ void show_free_areas(unsigned int filter
> K(node_page_state(pgdat, NR_FILE_MAPPED)),
> K(node_page_state(pgdat, NR_FILE_DIRTY)),
> K(node_page_state(pgdat, NR_WRITEBACK)),
> + K(node_page_state(pgdat, NR_SHMEM)),
> #ifdef CONFIG_TRANSPARENT_HUGEPAGE
> K(node_page_state(pgdat, NR_SHMEM_THPS) * HPAGE_PMD_NR),
> K(node_page_state(pgdat, NR_SHMEM_PMDMAPPED)
> * HPAGE_PMD_NR),
> K(node_page_state(pgdat, NR_ANON_THPS) * HPAGE_PMD_NR),
> #endif
> - K(node_page_state(pgdat, NR_SHMEM)),
> K(node_page_state(pgdat, NR_WRITEBACK_TEMP)),
> K(node_page_state(pgdat, NR_UNSTABLE_NFS)),
> node_page_state(pgdat, NR_PAGES_SCANNED),
> _
>
> huh. It looks like this has been broken for nearly a year, by
>
> : commit 11fb998986a72aa7e997d96d63d52582a01228c5
> : Author: Mel Gorman <mgorman@techsingularity.net>
> : AuthorDate: Thu Jul 28 15:46:20 2016 -0700
> : Commit: Linus Torvalds <torvalds@linux-foundation.org>
> : CommitDate: Thu Jul 28 16:07:41 2016 -0700
> :
> : mm: move most file-based accounting to the node
>
Yes, this was careless. Thanks for catching it Alexander.
> I'm surprised nobody noticed until now.
>
Probably because vmstat was not affected which is consumed more often
than the output from sysrq or an oom kill message.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-04-04 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-24 17:48 Alexander Polakov
2017-04-03 22:11 ` Andrew Morton
2017-04-04 14:19 ` Mel Gorman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170404141907.eomyynht4vlhu2ni@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=apolyakov@beget.ru \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox