From: Michal Hocko <mhocko@kernel.org>
To: joeyli <jlee@suse.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kani Toshimitsu <toshi.kani@hpe.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
linux-api@vger.kernel.org
Subject: Re: memory hotplug and force_remove
Date: Fri, 31 Mar 2017 12:55:05 +0200 [thread overview]
Message-ID: <20170331105505.GM27098@dhcp22.suse.cz> (raw)
In-Reply-To: <20170331104905.GA28365@linux-l9pv.suse>
On Fri 31-03-17 18:49:05, Joey Lee wrote:
> Hi Michal,
>
> On Fri, Mar 31, 2017 at 10:30:17AM +0200, Michal Hocko wrote:
[...]
> > @@ -241,11 +232,10 @@ static int acpi_scan_try_to_offline(struct acpi_device *device)
> > acpi_walk_namespace(ACPI_TYPE_ANY, handle, ACPI_UINT32_MAX,
> > NULL, acpi_bus_offline, (void *)true,
> > (void **)&errdev);
> > - if (!errdev || acpi_force_hot_remove)
> > + if (!errdev)
> > acpi_bus_offline(handle, 0, (void *)true,
> > (void **)&errdev);
> > -
> > - if (errdev && !acpi_force_hot_remove) {
> > + else {
> ^^^^^^^^^^^^^
> Here should still checks the parent's errdev state then rollback
> parent/children to online state:
>
> - if (errdev && !acpi_force_hot_remove) {
> + if (errdev) {
You are right, I have missed that acpi_bus_offline modifies errdev.
Thanks for spotting that! Updated patch is below.
---
next prev parent reply other threads:[~2017-03-31 10:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 19:29 Michal Hocko
2017-03-20 21:24 ` Rafael J. Wysocki
2017-03-21 16:13 ` joeyli
2017-03-28 7:58 ` Michal Hocko
2017-03-28 15:22 ` Rafael J. Wysocki
2017-03-30 8:47 ` Jiri Kosina
2017-03-30 16:20 ` Michal Hocko
2017-03-30 16:57 ` joeyli
2017-03-30 20:15 ` Rafael J. Wysocki
2017-03-31 0:00 ` joeyli
2017-03-31 8:30 ` Michal Hocko
2017-03-31 10:49 ` joeyli
2017-03-31 10:55 ` Michal Hocko [this message]
2017-03-31 11:55 ` joeyli
2017-03-31 12:02 ` Michal Hocko
2017-03-31 22:35 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331105505.GM27098@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=jkosina@suse.cz \
--cc=jlee@suse.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rjw@rjwysocki.net \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox