linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Michal Hocko <mhocko@kernel.org>
To: linux-mm@kvack.org
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Reza Arbab <arbab@linux.vnet.ibm.com>,
	Yasuaki Ishimatsu <yasu.isimatu@gmail.com>,
	Tang Chen <tangchen@cn.fujitsu.com>,
	qiuxishi@huawei.com, Kani Toshimitsu <toshi.kani@hpe.com>,
	slaoub@gmail.com, Joonsoo Kim <js1304@gmail.com>,
	Andi Kleen <ak@linux.intel.com>,
	Zhang Zhen <zhenzhang.zhang@huawei.com>,
	David Rientjes <rientjes@google.com>,
	Daniel Kiper <daniel.kiper@oracle.com>,
	Igor Mammedov <imammedo@redhat.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Michal Hocko <mhocko@suse.com>,
	Chris Metcalf <cmetcalf@mellanox.com>
Subject: [PATCH 2/6] mm, tile: drop arch_{add,remove}_memory
Date: Thu, 30 Mar 2017 13:54:50 +0200	[thread overview]
Message-ID: <20170330115454.32154-3-mhocko@kernel.org> (raw)
In-Reply-To: <20170330115454.32154-1-mhocko@kernel.org>

From: Michal Hocko <mhocko@suse.com>

these functions are unreachable because tile doesn't support memory
hotplug becasuse it doesn't select ARCH_ENABLE_MEMORY_HOTPLUG nor
it supports SPARSEMEM.

This code hasn't been compiled for a while obviously because nobody has
noticed that __add_pages has a different signature since 2009.

Cc: Chris Metcalf <cmetcalf@mellanox.com>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
 arch/tile/mm/init.c | 30 ------------------------------
 1 file changed, 30 deletions(-)

diff --git a/arch/tile/mm/init.c b/arch/tile/mm/init.c
index 3a97e4d7205c..5f757e04bcd2 100644
--- a/arch/tile/mm/init.c
+++ b/arch/tile/mm/init.c
@@ -857,36 +857,6 @@ void __init mem_init(void)
 #endif
 }
 
-/*
- * this is for the non-NUMA, single node SMP system case.
- * Specifically, in the case of x86, we will always add
- * memory to the highmem for now.
- */
-#ifndef CONFIG_NEED_MULTIPLE_NODES
-int arch_add_memory(u64 start, u64 size, bool for_device)
-{
-	struct pglist_data *pgdata = &contig_page_data;
-	struct zone *zone = pgdata->node_zones + MAX_NR_ZONES-1;
-	unsigned long start_pfn = start >> PAGE_SHIFT;
-	unsigned long nr_pages = size >> PAGE_SHIFT;
-
-	return __add_pages(zone, start_pfn, nr_pages);
-}
-
-int remove_memory(u64 start, u64 size)
-{
-	return -EINVAL;
-}
-
-#ifdef CONFIG_MEMORY_HOTREMOVE
-int arch_remove_memory(u64 start, u64 size)
-{
-	/* TODO */
-	return -EBUSY;
-}
-#endif
-#endif
-
 struct kmem_cache *pgd_cache;
 
 void __init pgtable_cache_init(void)
-- 
2.11.0

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2017-03-30 11:55 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 11:54 [PATCH 0/6] mm: make movable onlining suck less Michal Hocko
2017-03-30 11:54 ` [PATCH 1/6] mm: get rid of zone_is_initialized Michal Hocko
2017-03-31  3:39   ` Hillf Danton
2017-03-31  6:43     ` Michal Hocko
2017-03-31  6:48       ` Michal Hocko
2017-03-31  7:39   ` [PATCH v1 " Michal Hocko
2017-04-05  8:14     ` Michal Hocko
2017-04-05  9:06       ` Igor Mammedov
2017-04-05  9:23         ` Michal Hocko
2017-03-30 11:54 ` Michal Hocko [this message]
2017-03-30 15:41   ` [PATCH 2/6] mm, tile: drop arch_{add,remove}_memory Chris Metcalf
2017-03-30 11:54 ` [PATCH 3/6] mm: remove return value from init_currently_empty_zone Michal Hocko
2017-03-31  3:49   ` Hillf Danton
2017-03-31  6:49     ` Michal Hocko
2017-03-31  7:06       ` Hillf Danton
2017-03-31  7:18         ` Michal Hocko
2017-03-31  7:43   ` Michal Hocko
2017-04-03 21:22   ` Reza Arbab
2017-04-04  7:30     ` Michal Hocko
2017-03-30 11:54 ` [PATCH 4/6] mm, memory_hotplug: use node instead of zone in can_online_high_movable Michal Hocko
2017-03-30 11:54 ` [PATCH 5/6] mm, memory_hotplug: do not associate hotadded memory to zones until online Michal Hocko
2017-03-31  6:18   ` Hillf Danton
2017-03-31  6:50     ` Michal Hocko
2017-04-04 12:21   ` Tobias Regnery
2017-04-04 12:45     ` Michal Hocko
2017-04-06  8:14   ` Michal Hocko
2017-04-06 12:46   ` Michal Hocko
2017-03-30 11:54 ` [PATCH 6/6] mm, memory_hotplug: remove unused cruft after memory hotplug rework Michal Hocko
2017-03-31  7:46   ` Michal Hocko
2017-03-31 19:19 ` [PATCH 0/6] mm: make movable onlining suck less Heiko Carstens
2017-04-03  7:34   ` Michal Hocko
2017-04-03 11:55 ` Michal Hocko
2017-04-03 12:20   ` Igor Mammedov
2017-04-03 19:58   ` Reza Arbab
2017-04-03 20:23     ` Michal Hocko
2017-04-03 20:42       ` Reza Arbab
2017-04-04  7:23         ` Michal Hocko
2017-04-04  7:34           ` Michal Hocko
2017-04-04  8:23             ` Michal Hocko
2017-04-04 15:59               ` Reza Arbab
2017-04-04 16:02               ` Reza Arbab
2017-04-04 16:44                 ` Michal Hocko
2017-04-04 18:30                   ` Reza Arbab
2017-04-04 19:41                     ` Michal Hocko
2017-04-04 21:43                       ` Reza Arbab
2017-04-05  6:42                         ` Michal Hocko
2017-04-05  9:24                           ` Michal Hocko
2017-04-05 14:53                             ` Reza Arbab
2017-04-05 15:42                               ` Michal Hocko
2017-04-05 17:32                                 ` Reza Arbab
2017-04-05 18:15                                   ` Michal Hocko
2017-04-05 19:39                                     ` Michal Hocko
2017-04-05 21:02                                     ` Michal Hocko
2017-04-06 11:07                                       ` Michal Hocko
2017-04-05 15:48                           ` Reza Arbab
2017-04-05 16:34                             ` Michal Hocko
2017-04-05 20:55                               ` Reza Arbab
2017-04-06  9:25                               ` Michal Hocko
2017-04-05 13:52                         ` Michal Hocko
2017-04-05 15:23                           ` Reza Arbab
2017-04-05  6:36                       ` Michal Hocko
2017-04-06 13:08 ` Michal Hocko
2017-04-06 15:24   ` Reza Arbab
2017-04-06 15:41     ` Michal Hocko
2017-04-06 15:46       ` Reza Arbab
2017-04-06 16:21         ` Michal Hocko
2017-04-06 16:24           ` Mel Gorman
2017-04-06 16:55           ` Mel Gorman
2017-04-06 17:12             ` Michal Hocko
2017-04-06 17:46               ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170330115454.32154-3-mhocko@kernel.org \
    --to=mhocko@kernel.org \
    --cc=aarcange@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arbab@linux.vnet.ibm.com \
    --cc=cmetcalf@mellanox.com \
    --cc=daniel.kiper@oracle.com \
    --cc=imammedo@redhat.com \
    --cc=js1304@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@suse.de \
    --cc=mhocko@suse.com \
    --cc=qiuxishi@huawei.com \
    --cc=rientjes@google.com \
    --cc=slaoub@gmail.com \
    --cc=tangchen@cn.fujitsu.com \
    --cc=toshi.kani@hpe.com \
    --cc=vbabka@suse.cz \
    --cc=vkuznets@redhat.com \
    --cc=yasu.isimatu@gmail.com \
    --cc=zhenzhang.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox