From: Andi Kleen <andi@firstfloor.org>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: Andi Kleen <andi@firstfloor.org>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] Is MADV_HWPOISON supposed to work only on faulted-in pages?
Date: Tue, 28 Mar 2017 13:26:52 -0700 [thread overview]
Message-ID: <20170328202652.GC8285@two.firstfloor.org> (raw)
In-Reply-To: <20170328082506.GA30388@rei>
> Well I disagree, the reason why the test fails is that MADV_HWPOISON on
> not-faulted private mappings fails silently, which is a bug, albeit
> minor one. If something is not implemented, it should report a failure,
> the usual error return would be EINVAL in this case.
>
> It appears that it fails with EBUSY on first try on newer kernels, but
> still fails silently when we try for a second time.
>
> Why can't we simply check if the page is faulted or not and return error
> in the latter case?
It's a debug interface. You're supposed to know what you're doing.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-03-28 20:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 15:41 Jan Stancek
2017-02-20 5:00 ` Naoya Horiguchi
2017-02-23 3:23 ` Naoya Horiguchi
2017-02-25 2:28 ` Yisheng Xie
2017-02-27 1:20 ` Naoya Horiguchi
2017-02-27 4:27 ` Zi Yan
2017-02-27 6:33 ` Naoya Horiguchi
2017-02-27 16:10 ` Zi Yan
2017-03-14 13:20 ` [LTP] " Cyril Hrubis
2017-03-27 12:08 ` Richard Palethorpe
2017-03-27 23:54 ` Andi Kleen
2017-03-28 8:25 ` [LTP] " Cyril Hrubis
2017-03-28 20:26 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328202652.GC8285@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=chrubis@suse.cz \
--cc=linux-mm@kvack.org \
--cc=ltp@lists.linux.it \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox