From: Andrew Morton <akpm@linux-foundation.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Hugh Dickins <hughd@google.com>, Shaohua Li <shli@kernel.org>,
Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@redhat.com>,
Andrea Arcangeli <aarcange@redhat.com>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH -mm -v7 0/9] THP swap: Delay splitting THP during swapping out
Date: Tue, 28 Mar 2017 15:13:58 -0700 [thread overview]
Message-ID: <20170328151358.80a14e40d1a431084bc27db4@linux-foundation.org> (raw)
In-Reply-To: <20170328053209.25876-1-ying.huang@intel.com>
On Tue, 28 Mar 2017 13:32:00 +0800 "Huang, Ying" <ying.huang@intel.com> wrote:
> Hi, Andrew, could you help me to check whether the overall design is
> reasonable?
>
> Hi, Hugh, Shaohua, Minchan and Rik, could you help me to review the
> swap part of the patchset? Especially [1/9], [3/9], [4/9], [5/9],
> [6/9], [9/9].
>
> Hi, Andrea could you help me to review the THP part of the patchset?
> Especially [2/9], [7/9] and [8/9].
>
> Hi, Johannes, Michal and Vladimir, I am not very confident about the
> memory cgroup part, especially [2/9]. Could you help me to review it?
>
> And for all, Any comment is welcome!
>
>
> Recently, the performance of the storage devices improved so fast that
> we cannot saturate the disk bandwidth with single logical CPU when do
> page swap out even on a high-end server machine. Because the
> performance of the storage device improved faster than that of single
> logical CPU. And it seems that the trend will not change in the near
> future. On the other hand, the THP becomes more and more popular
> because of increased memory size. So it becomes necessary to optimize
> THP swap performance.
I'll merge this patchset for testing purposes, but I don't believe that
it has yet had sufficient review. And thanks for drawing our attention
to those parts where you believe close review is needed - that helps.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-28 22:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 5:32 Huang, Ying
2017-03-28 5:32 ` [PATCH -mm -v7 1/9] mm, swap: Make swap cluster size same of THP size on x86_64 Huang, Ying
2017-03-28 23:30 ` Kirill A. Shutemov
2017-03-29 1:10 ` Huang, Ying
2017-03-29 16:55 ` Johannes Weiner
2017-03-30 0:45 ` Huang, Ying
2017-03-31 14:56 ` Johannes Weiner
2017-04-01 3:29 ` Huang, Ying
2017-03-28 5:32 ` [PATCH -mm -v7 2/9] mm, memcg: Support to charge/uncharge multiple swap entries Huang, Ying
2017-03-29 16:57 ` Johannes Weiner
2017-03-30 0:53 ` Huang, Ying
2017-03-31 14:59 ` Johannes Weiner
2017-03-28 5:32 ` [PATCH -mm -v7 3/9] mm, THP, swap: Add swap cluster allocate/free functions Huang, Ying
2017-03-28 5:32 ` [PATCH -mm -v7 4/9] mm, THP, swap: Add get_huge_swap_page() Huang, Ying
2017-03-29 17:08 ` Johannes Weiner
2017-03-30 4:28 ` Huang, Ying
2017-03-31 15:24 ` Johannes Weiner
2017-04-01 3:32 ` Huang, Ying
2017-03-28 5:32 ` [PATCH -mm -v7 5/9] mm, THP, swap: Support to clear SWAP_HAS_CACHE for huge page Huang, Ying
2017-03-28 5:32 ` [PATCH -mm -v7 6/9] mm, THP, swap: Support to add/delete THP to/from swap cache Huang, Ying
2017-03-28 5:32 ` [PATCH -mm -v7 7/9] mm, THP: Add can_split_huge_page() Huang, Ying
2017-03-28 5:32 ` [PATCH -mm -v7 8/9] mm, THP, swap: Support to split THP in swap cache Huang, Ying
2017-03-28 5:32 ` [PATCH -mm -v7 9/9] mm, THP, swap: Delay splitting THP during swap out Huang, Ying
2017-03-29 17:16 ` Johannes Weiner
2017-03-30 4:15 ` Huang, Ying
2017-03-31 14:49 ` Johannes Weiner
2017-04-01 2:54 ` Huang, Ying
2017-03-28 22:13 ` Andrew Morton [this message]
2017-03-29 8:52 ` [PATCH -mm -v7 0/9] THP swap: Delay splitting THP during swapping out Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328151358.80a14e40d1a431084bc27db4@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aarcange@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
--cc=vdavydov@virtuozzo.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox