From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id 99FD16B03A1 for ; Tue, 28 Mar 2017 05:30:43 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id z36so51551100wrc.14 for ; Tue, 28 Mar 2017 02:30:43 -0700 (PDT) Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com. [2a00:1450:400c:c0c::243]) by mx.google.com with ESMTPS id 50si4021743wra.228.2017.03.28.02.30.42 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Mar 2017 02:30:42 -0700 (PDT) Received: by mail-wr0-x243.google.com with SMTP id p52so17877086wrc.2 for ; Tue, 28 Mar 2017 02:30:42 -0700 (PDT) Date: Tue, 28 Mar 2017 12:30:40 +0300 From: "Kirill A. Shutemov" Subject: Re: [PATCH 6/8] x86/dump_pagetables: Add support 5-level paging Message-ID: <20170328093040.wayhvqxijreps2mq@node.shutemov.name> References: <20170327162925.16092-1-kirill.shutemov@linux.intel.com> <20170327162925.16092-7-kirill.shutemov@linux.intel.com> <20170328061259.GC20135@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170328061259.GC20135@gmail.com> Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: "Kirill A. Shutemov" , Linus Torvalds , Andrew Morton , x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andi Kleen , Dave Hansen , Andy Lutomirski , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Tue, Mar 28, 2017 at 08:12:59AM +0200, Ingo Molnar wrote: > > * Kirill A. Shutemov wrote: > > > +#if PTRS_PER_P4D > 1 > > + > > +static void walk_p4d_level(struct seq_file *m, struct pg_state *st, pgd_t addr, > > + unsigned long P) > > Pretty ugly line break. Either don't break the line, or break it in a more logical > place, like: > > static void > walk_p4d_level(struct seq_file *m, struct pg_state *st, pgd_t addr, unsigned long P) > > > + start = (p4d_t *) pgd_page_vaddr(addr); > > The space between the type cast and the function invocation is not needed. Both style issues you have pointed to are inherited from handling of other page table levels. Do you want me to adjust them too? This kind of inconsistency bother me more than style issues itself. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org