From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
Ingo Molnar <mingo@kernel.org>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Fengguang Wu <fengguang.wu@intel.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
LKP <lkp@01.org>, Linus Torvalds <torvalds@linux-foundation.org>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [x86/mm/gup] 2947ba054a [ 71.329069] kernel BUG at include/linux/pagemap.h:151!
Date: Fri, 24 Mar 2017 14:47:09 +0300 [thread overview]
Message-ID: <20170324114709.pcytvyb3d6ajux33@black.fi.intel.com> (raw)
In-Reply-To: <20170324105153.xvy5rcuawicqoanl@hirez.programming.kicks-ass.net>
On Fri, Mar 24, 2017 at 11:51:53AM +0100, Peter Zijlstra wrote:
> On Fri, Mar 24, 2017 at 01:24:36PM +0300, Kirill A. Shutemov wrote:
>
> > I'm not sure what is the best way to fix this.
> > Few options:
> > - Drop the VM_BUG();
> > - Bump preempt count during __get_user_pages_fast();
> > - Use get_page() instead of page_cache_get_speculative() on x86.
> >
> > Any opinions?
>
> I think I'm in favour of the first; either remove or amend to include
> irqs_disabled() or so.
>
> This in favour of keeping the variants of GUP down.
Something like this?
-------------------8<-----------------------
next prev parent reply other threads:[~2017-03-24 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-19 22:51 Fengguang Wu
2017-03-24 10:24 ` Kirill A. Shutemov
2017-03-24 10:51 ` Peter Zijlstra
2017-03-24 11:47 ` Kirill A. Shutemov [this message]
2017-03-27 15:30 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170324114709.pcytvyb3d6ajux33@black.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@01.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox