From: Michal Hocko <mhocko@kernel.org>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Andi Kleen" <ak@linux.intel.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Shaohua Li" <shli@kernel.org>, "Rik van Riel" <riel@redhat.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Tim Chen" <tim.c.chen@linux.intel.com>,
"Mel Gorman" <mgorman@techsingularity.net>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Aaron Lu" <aaron.lu@intel.com>,
"Hugh Dickins" <hughd@google.com>,
"Minchan Kim" <minchan@kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Vegard Nossum" <vegard.nossum@oracle.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 4/5] mm, swap: Try kzalloc before vzalloc
Date: Fri, 17 Mar 2017 12:47:33 +0100 [thread overview]
Message-ID: <20170317114732.GF26298@dhcp22.suse.cz> (raw)
In-Reply-To: <20170317064635.12792-4-ying.huang@intel.com>
On Fri 17-03-17 14:46:22, Huang, Ying wrote:
> +void *swap_kvzalloc(size_t size)
> +{
> + void *p;
> +
> + p = kzalloc(size, GFP_KERNEL | __GFP_NOWARN);
> + if (!p)
> + p = vzalloc(size);
> +
> + return p;
> +}
please do not invent your own kvmalloc implementation when we already
have on in mmotm tree.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-17 11:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 6:46 [PATCH 1/5] mm, swap: Fix comment in __read_swap_cache_async Huang, Ying
2017-03-17 6:46 ` [PATCH 2/5] mm, swap: Improve readability via make spin_lock/unlock balanced Huang, Ying
2017-03-17 6:46 ` [PATCH 3/5] mm, swap: Avoid lock swap_avail_lock when held cluster lock Huang, Ying
2017-03-17 6:46 ` [PATCH 4/5] mm, swap: Try kzalloc before vzalloc Huang, Ying
2017-03-17 8:52 ` David Rientjes
2017-03-17 11:47 ` Michal Hocko [this message]
2017-03-20 1:01 ` Huang, Ying
2017-03-17 6:46 ` [PATCH 5/5] mm, swap: Sort swap entries before free Huang, Ying
2017-03-17 12:42 ` [PATCH 1/5] mm, swap: Fix comment in __read_swap_cache_async Rafael Aquini
2017-03-20 2:07 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170317114732.GF26298@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=aaron.lu@intel.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jglisse@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
--cc=mingo@kernel.org \
--cc=riel@redhat.com \
--cc=shli@kernel.org \
--cc=tim.c.chen@linux.intel.com \
--cc=vegard.nossum@oracle.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox