From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f72.google.com (mail-wm0-f72.google.com [74.125.82.72]) by kanga.kvack.org (Postfix) with ESMTP id 0A84B6B0038 for ; Mon, 13 Mar 2017 04:44:32 -0400 (EDT) Received: by mail-wm0-f72.google.com with SMTP id g8so12744865wmg.7 for ; Mon, 13 Mar 2017 01:44:31 -0700 (PDT) Received: from mx2.suse.de (mx2.suse.de. [195.135.220.15]) by mx.google.com with ESMTPS id f21si23678328wrf.78.2017.03.13.01.44.30 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 13 Mar 2017 01:44:30 -0700 (PDT) Date: Mon, 13 Mar 2017 09:44:29 +0100 From: Michal Hocko Subject: Re: [PATCH] mm, gup: fix typo in gup_p4d_range() Message-ID: <20170313084429.GB31518@dhcp22.suse.cz> References: <20170313052213.11411-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170313052213.11411-1-kirill.shutemov@linux.intel.com> Sender: owner-linux-mm@kvack.org List-ID: To: "Kirill A. Shutemov" Cc: Linus Torvalds , Andrew Morton , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org On Mon 13-03-17 08:22:13, Kirill A. Shutemov wrote: > gup_p4d_range() should call gup_pud_range(), not itself. > > Signed-off-by: Kirill A. Shutemov > Reported-by: Chris Packham > Fixes: c2febafc6773 ("mm: convert generic code to 5-level paging") Upps, missed this one during the review. Thanks for catching that up Acked-by: Michal Hocko > --- > mm/gup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/gup.c b/mm/gup.c > index c74bad1bf6e8..04aa405350dc 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -1455,7 +1455,7 @@ static int gup_p4d_range(pgd_t pgd, unsigned long addr, unsigned long end, > if (!gup_huge_pd(__hugepd(p4d_val(p4d)), addr, > P4D_SHIFT, next, write, pages, nr)) > return 0; > - } else if (!gup_p4d_range(p4d, addr, next, write, pages, nr)) > + } else if (!gup_pud_range(p4d, addr, next, write, pages, nr)) > return 0; > } while (p4dp++, addr = next, addr != end); > > -- > 2.11.0 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org