From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linux-mm@kvack.org, mhocko@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: mark gup_pud_range as unused
Date: Mon, 13 Mar 2017 08:21:13 +0300 [thread overview]
Message-ID: <20170313052113.4mgqf7a6vsfyeocg@black.fi.intel.com> (raw)
In-Reply-To: <20170313035837.29719-1-chris.packham@alliedtelesis.co.nz>
On Mon, Mar 13, 2017 at 04:58:37PM +1300, Chris Packham wrote:
> The last caller to gup_pud_range was removed in commit c2febafc6773
> ("mm: convert generic code to 5-level paging"). Mark it as unused to
> silence a warning from gcc.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> I saw this warning when compiling 4.11-rc2 with -Werror. An equally valid fix
> would be to remove the function entirely but I went for the less invasive
> approach.
Thanks for report. But real fix is to call gup_pud_range() from
gup_p4d_range(), not itself.
I'll post a fix.
Reported-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Reported-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
--
Kirill A. Shutemov
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-03-13 5:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 3:58 Chris Packham
2017-03-13 5:21 ` Kirill A. Shutemov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313052113.4mgqf7a6vsfyeocg@black.fi.intel.com \
--to=kirill.shutemov@linux.intel.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox