From: Chris Packham <chris.packham@alliedtelesis.co.nz>
To: linux-mm@kvack.org, kirill.shutemov@linux.intel.com, mhocko@suse.com
Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>,
linux-kernel@vger.kernel.org
Subject: [PATCH] mm: mark gup_pud_range as unused
Date: Mon, 13 Mar 2017 16:58:37 +1300 [thread overview]
Message-ID: <20170313035837.29719-1-chris.packham@alliedtelesis.co.nz> (raw)
The last caller to gup_pud_range was removed in commit c2febafc6773
("mm: convert generic code to 5-level paging"). Mark it as unused to
silence a warning from gcc.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
I saw this warning when compiling 4.11-rc2 with -Werror. An equally valid fix
would be to remove the function entirely but I went for the less invasive
approach.
mm/gup.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/gup.c b/mm/gup.c
index c74bad1bf6e8..10f5c582273c 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -1409,8 +1409,9 @@ static int gup_pmd_range(pud_t pud, unsigned long addr, unsigned long end,
return 1;
}
-static int gup_pud_range(p4d_t p4d, unsigned long addr, unsigned long end,
- int write, struct page **pages, int *nr)
+static int __maybe_unused gup_pud_range(p4d_t p4d, unsigned long addr,
+ unsigned long end, int write,
+ struct page **pages, int *nr)
{
unsigned long next;
pud_t *pudp;
--
2.11.0.24.ge6920cf
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2017-03-13 3:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-13 3:58 Chris Packham [this message]
2017-03-13 5:21 ` Kirill A. Shutemov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170313035837.29719-1-chris.packham@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox